Issue 11594008: Revert 173477

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11594008: Revert 173477 (Closed)

Created:
8 years ago by dpapad

Modified:
8 years ago

Reviewers:
erikwright (departed)

CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, derat+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 173477 > Decouple input_method from BrowserThread (and content/). > > BUG=164375 > > > Review URL: https://chromiumcodereview.appspot.com/11558017 TBR=erikwright@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173478

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+91 lines, -265 lines)			Patch
M	chrome/browser/chromeos/input_method/DEPS	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/ibus_controller.h	View	2 chunks	+1 line, -9 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/ibus_controller.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/ibus_controller_impl.h	View	5 chunks	+4 lines, -21 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/ibus_controller_impl.cc	View	10 chunks	+35 lines, -38 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/ibus_controller_unittest.cc	View	1 chunk	+1 line, -8 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_delegate.h	View	2 chunks	+0 lines, -13 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_delegate_impl.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_delegate_impl.cc	View	2 chunks	+0 lines, -16 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_manager_impl.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/mock_input_method_delegate.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/mock_input_method_delegate.cc	View	2 chunks	+0 lines, -15 lines	0 comments	Download
D	chrome/browser/chromeos/input_method/mock_sequenced_task_runner.h	View	1 chunk	+0 lines, -27 lines	0 comments	Download
D	chrome/browser/chromeos/input_method/mock_sequenced_task_runner.cc	View	1 chunk	+0 lines, -33 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/mock_xkeyboard.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/mock_xkeyboard.cc	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/xkeyboard.h	View	2 chunks	+8 lines, -15 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/xkeyboard.cc	View	10 chunks	+18 lines, -25 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/xkeyboard_unittest.cc	View	5 chunks	+12 lines, -8 lines	0 comments	Download
M	chrome/browser/chromeos/preferences.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages