[Download Notification] Show preview if downloaded file is image

chrome/browser/download/notification/download_notification_item_unittest.cc

Index: chrome/browser/download/notification/download_notification_item_unittest.cc
diff --git a/chrome/browser/download/notification/download_notification_item_unittest.cc b/chrome/browser/download/notification/download_notification_item_unittest.cc
index 9939f14acad69814f08c3ec6e2ae896f9ddbce3c..e2252b2e42c3b2af30f220259950f4e2079c14a8 100644
--- a/chrome/browser/download/notification/download_notification_item_unittest.cc
+++ b/chrome/browser/download/notification/download_notification_item_unittest.cc
@@ -22,6 +22,7 @@
 
 using testing::NiceMock;
 using testing::Return;
+using testing::ReturnRef;
 using testing::_;
 
 namespace {
@@ -67,6 +68,8 @@ class MockDownloadNotificationItemDelegate
   size_t on_download_stopped_call_count_;
 };
 
+static base::FilePath kDownloadItemTargetPath("/tmp/TITLE.bin");

[Lei Zhang, 2015/06/12 07:26:37]

This generates a static initializer. If this wasn't a test, the sizes step on
the buildbots would fail.

The solution here is to use a POD string of type base::FilePath::StringType, and
wrapper it in base::FilePath() when used below.

[Lei Zhang, 2015/06/12 07:26:37]

You don't need static in an anonymous namespace.

[yoshiki, 2015/06/12 08:00:20]

Done.

[Lei Zhang, 2015/06/13 00:27:26]

Please remove the static keyword.

[yoshiki, 2015/06/16 16:41:42]

Done.

+
 }  // anonymous namespace
 
 namespace test {
@@ -97,6 +100,8 @@ class DownloadNotificationItemTest : public testing::Test {
     ON_CALL(*download_item_, IsDangerous()).WillByDefault(Return(false));
     ON_CALL(*download_item_, GetFileNameToReportUser())
         .WillByDefault(Return(base::FilePath("TITLE.bin")));
+    ON_CALL(*download_item_, GetTargetFilePath())
+        .WillByDefault(ReturnRef(kDownloadItemTargetPath));
     ON_CALL(*download_item_, GetDangerType())
         .WillByDefault(Return(content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS));
     ON_CALL(*download_item_, IsDone()).WillByDefault(Return(false));