[Download Notification] Show preview if downloaded file is image

chrome/browser/download/notification/download_notification_item_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/notification/download_notification_item.h"
 
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "base/test/test_simple_task_runner.h"
 #include "base/thread_task_runner_handle.h"
 #include "chrome/browser/notifications/notification_test_util.h"
 #include "chrome/browser/notifications/platform_notification_service_impl.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "chrome/test/base/testing_profile.h"
 #include "chrome/test/base/testing_profile_manager.h"
 #include "content/public/test/mock_download_item.h"
 #include "content/public/test/mock_download_manager.h"
 #include "content/public/test/test_browser_thread.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/message_center/fake_message_center.h"
 
 using testing::NiceMock;
 using testing::Return;
+using testing::ReturnRef;
 using testing::_;
 
 namespace {
 
 class MockDownloadNotificationItemDelegate
     : public DownloadNotificationItem::Delegate {
  public:
   MockDownloadNotificationItemDelegate()
       : on_download_removed_call_count_(0u),
         on_download_started_call_count_(0u),
@@ skipping 25 matching lines @@
   size_t GetOnDownloadStoppedCallCount() {
     return on_download_stopped_call_count_;
   }
 
  private:
   size_t on_download_removed_call_count_;
   size_t on_download_started_call_count_;
   size_t on_download_stopped_call_count_;
 };
 
+static base::FilePath kDownloadItemTargetPath("/tmp/TITLE.bin");

[Lei Zhang, 2015/06/12 07:26:37]

This generates a static initializer. If this wasn't a test, the sizes step on
the buildbots would fail.

The solution here is to use a POD string of type base::FilePath::StringType, and
wrapper it in base::FilePath() when used below.

[Lei Zhang, 2015/06/12 07:26:37]

You don't need static in an anonymous namespace.

[yoshiki, 2015/06/12 08:00:20]

Done.

[Lei Zhang, 2015/06/13 00:27:26]

Please remove the static keyword.

[yoshiki, 2015/06/16 16:41:42]

Done.

+
 }  // anonymous namespace
 
 namespace test {
 
 class DownloadNotificationItemTest : public testing::Test {
  public:
   DownloadNotificationItemTest()
       : ui_thread_(content::BrowserThread::UI, &message_loop_),
         profile_(nullptr) {}
 
@@ skipping 10 matching lines @@
     DownloadNotificationItem::SetStubNotificationUIManagerForTesting(
         ui_manager_.get());
 
     download_item_.reset(new NiceMock<content::MockDownloadItem>());
     ON_CALL(*download_item_, GetId()).WillByDefault(Return(12345));
     ON_CALL(*download_item_, GetState())
         .WillByDefault(Return(content::DownloadItem::IN_PROGRESS));
     ON_CALL(*download_item_, IsDangerous()).WillByDefault(Return(false));
     ON_CALL(*download_item_, GetFileNameToReportUser())
         .WillByDefault(Return(base::FilePath("TITLE.bin")));
+    ON_CALL(*download_item_, GetTargetFilePath())
+        .WillByDefault(ReturnRef(kDownloadItemTargetPath));
     ON_CALL(*download_item_, GetDangerType())
         .WillByDefault(Return(content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS));
     ON_CALL(*download_item_, IsDone()).WillByDefault(Return(false));
   }
 
   void TearDown() override {
     download_notification_item_.reset();
     profile_manager_.reset();
     message_center::MessageCenter::Shutdown();
     testing::Test::TearDown();
@@ skipping 179 matching lines @@
 
   // Checks OnDownloadRemoved().
   EXPECT_EQ(0u, delegate_.GetOnDownloadRemovedCallCount());
   download_item_->NotifyObserversDownloadRemoved();
   EXPECT_EQ(1u, delegate_.GetOnDownloadRemovedCallCount());
 
   download_item_.reset();
 }
 
 }  // namespace test