Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1159303003: Sync the Selection interface with the spec (Closed)

Created:
5 years, 6 months ago by philipj_slow
Modified:
5 years, 6 months ago
Reviewers:
yoichio, Jens Widell
CC:
blink-reviews, vivekg, arv+blink, Inactive, vivekg_samsung
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync the Selection interface with the spec http://w3c.github.io/selection-api/#idl-def-Selection There are no changes to the generated code other than order and the allowPartial -> allowPartialContainment renaming. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196219

Patch Set 1 #

Patch Set 2 : removeRange TODO #

Total comments: 1

Patch Set 3 : add review and spec bug for [NotEnumerable] toString() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -39 lines) Patch
M Source/core/editing/Selection.idl View 1 2 1 chunk +37 lines, -39 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
philipj_slow
yoichio@, are you OK with your name on these TODOs? jl@, sanity-check?
5 years, 6 months ago (2015-05-30 23:00:09 UTC) #2
yoichio
I'm OK about TODO(yoichio).
5 years, 6 months ago (2015-06-01 02:22:04 UTC) #3
Jens Widell
LGTM https://codereview.chromium.org/1159303003/diff/20001/Source/core/editing/Selection.idl File Source/core/editing/Selection.idl (right): https://codereview.chromium.org/1159303003/diff/20001/Source/core/editing/Selection.idl#newcode65 Source/core/editing/Selection.idl:65: // TODO(philipj): The stringifier should be enumerable. See ...
5 years, 6 months ago (2015-06-01 05:58:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159303003/40001
5 years, 6 months ago (2015-06-01 10:39:41 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 12:19:11 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196219

Powered by Google App Engine
This is Rietveld 408576698