Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11592011: events: Update mouse-event handlers to not return EventResult. (Closed)

Created:
8 years ago by sadrul
Modified:
8 years ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, ben+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, dcheng, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su, Ben Goodger (Google)
Visibility:
Public.

Description

events: Update mouse-event handlers to not return EventResult. This is the last step. Once this is done, we can possibly hide EventResult. BUG=163618 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173653

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -261 lines) Patch
M ash/display/mouse_cursor_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/mouse_cursor_event_filter.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/drag_drop/drag_drop_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_controller.cc View 2 chunks +10 lines, -6 lines 0 comments Download
M ash/extended_desktop_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/launcher/launcher_tooltip_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/launcher/launcher_tooltip_manager.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M ash/launcher/launcher_tooltip_manager_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/magnifier/magnification_controller.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M ash/magnifier/partial_magnification_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/magnifier/partial_magnification_controller.cc View 2 chunks +1 line, -4 lines 0 comments Download
M ash/system/tray/tray_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_event_filter.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ash/tooltips/tooltip_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/tooltips/tooltip_controller.cc View 2 chunks +1 line, -2 lines 0 comments Download
M ash/wm/activation_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/activation_controller.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/app_list_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/app_list_controller.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/event_rewriter_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/event_rewriter_event_filter.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M ash/wm/panel_window_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panel_window_event_filter.cc View 3 chunks +13 lines, -17 lines 0 comments Download
M ash/wm/shelf_layout_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/system_gesture_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_gesture_event_filter.cc View 2 chunks +1 line, -2 lines 0 comments Download
M ash/wm/system_modal_container_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_modal_container_event_filter.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/wm/toplevel_window_event_handler.h View 2 chunks +6 lines, -10 lines 0 comments Download
M ash/wm/toplevel_window_event_handler.cc View 6 chunks +27 lines, -26 lines 0 comments Download
M ash/wm/user_activity_detector.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/user_activity_detector.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/user_activity_detector_unittest.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M ash/wm/window_manager_unittest.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M ash/wm/workspace/workspace_event_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_event_handler.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/immersive_mode_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/immersive_mode_controller.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/aura/gestures/gesture_recognizer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/root_window_unittest.cc View 4 chunks +5 lines, -8 lines 0 comments Download
M ui/aura/test/test_event_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/test_event_handler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/aura/test/test_window_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/test_window_delegate.cc View 2 chunks +1 line, -2 lines 0 comments Download
M ui/aura/window_unittest.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M ui/base/events/event_dispatcher_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/events/event_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/events/event_handler.cc View 1 chunk +2 lines, -9 lines 0 comments Download
M ui/base/events/event_target.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/events/event_target.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/views/corewm/compound_event_filter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/corewm/compound_event_filter.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M ui/views/corewm/focus_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/corewm/focus_controller.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/corewm/window_modality_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/corewm/window_modality_controller.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/view.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_activation_client.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_activation_client.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_window_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/x11_window_event_filter.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ui/views/widget/native_widget_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.cc View 2 chunks +10 lines, -6 lines 0 comments Download
M ui/views/widget/native_widget_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/widget/widget.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/widget.cc View 2 chunks +23 lines, -19 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 5 chunks +13 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sadrul
8 years ago (2012-12-17 15:05:48 UTC) #1
sadrul
+sky@ since ben@ is OOO
8 years ago (2012-12-17 19:17:58 UTC) #2
sky
8 years ago (2012-12-17 22:18:08 UTC) #3 
LGTM

Powered by Google App Engine
This is Rietveld 408576698