content/browser/web_contents/web_contents_impl_unittest.cc - Issue 1159183002: Improve process crash handling in RenderViewHost & mock RenderProcessHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl_unittest.cc

Issue 1159183002: Improve process crash handling in RenderViewHost & mock RenderProcessHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix for WebViewInteractiveUiTest.TextInputClientIsUpToDate Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura_unittest.cc ('k') | content/public/test/mock_render_process_host.h » ('j') | ui/views/controls/webview/webview_interactive_uitest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl_unittest.cc

diff --git a/content/browser/web_contents/web_contents_impl_unittest.cc b/content/browser/web_contents/web_contents_impl_unittest.cc

index c2d818967faf917aeb970db22a221d927a004347..ee8625e961ffbcdcbc0f83b1cd17db675dc19fea 100644

--- a/content/browser/web_contents/web_contents_impl_unittest.cc

+++ b/content/browser/web_contents/web_contents_impl_unittest.cc

@@ -1437,7 +1437,9 @@ TEST_F(WebContentsImplTest, TerminateHidesValidationMessage) {

contents()->SetDelegate(&fake_delegate);

EXPECT_FALSE(fake_delegate.hide_validation_message_was_called());

- // Crash the renderer.

+ // Initialize the RenderFrame and then simulate crashing the renderer

+ // process.

+ contents()->GetMainFrame()->InitializeRenderFrameIfNeeded();

contents()->GetMainFrame()->GetProcess()->SimulateCrash();

// Confirm HideValidationMessage was called.