Improve process crash handling in RenderViewHost & mock RenderProcessHost.

ui/views/controls/webview/webview_interactive_uitest.cc

Index: ui/views/controls/webview/webview_interactive_uitest.cc
diff --git a/ui/views/controls/webview/webview_interactive_uitest.cc b/ui/views/controls/webview/webview_interactive_uitest.cc
index d8598184e176d356a2fdc8551b6af5b57eb19fba..e13b24ea1c0f120f244cd9c4342b1ba9c474610d 100644
--- a/ui/views/controls/webview/webview_interactive_uitest.cc
+++ b/ui/views/controls/webview/webview_interactive_uitest.cc
@@ -7,6 +7,7 @@
 #include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "content/public/browser/web_contents.h"
+#include "content/public/test/mock_render_process_host.h"
 #include "content/public/test/test_browser_context.h"
 #include "content/public/test/test_browser_thread.h"
 #include "content/public/test/test_renderer_host.h"
@@ -89,6 +90,7 @@ TEST_F(WebViewInteractiveUiTest, TextInputClientIsUpToDate) {
 
   // Case 1: Creates a new WebContents.
   content::WebContents* web_contents1 = webview->GetWebContents();
+  web_contents1->GetRenderViewHost()->GetProcess()->Init();

[ncarter (slow), 2015/05/29 17:31:31]

web_contents1 is created via
[WebView::GetWebContents=>WebView::CreateWebContents=>WebViewTestViewsDelegate::CreateWebContents=>WebContentsTester::CreateTestWebContents=>TestWebContents::Create]

You need the RPH::Init call here because in test_renderer_host.cc you added an
RPH::Init call to RenderViewHostTestHarness::CreateTestWebContents and not to
TestWebContents::Create.

Would it be better to remove the RPH::Init call from
RenderViewHostTestHarness::CreateTestWebContents and add it to
TestWebContents::Create so that it's done automatically and consistently for
tests like this one?

[nasko, 2015/06/01 19:00:09]

Indeed it is better. Done!

   content::RenderViewHostTester::For(web_contents1->GetRenderViewHost())
       ->CreateRenderView(base::string16(), MSG_ROUTING_NONE, MSG_ROUTING_NONE,
                          -1, false);
@@ -101,6 +103,7 @@ TEST_F(WebViewInteractiveUiTest, TextInputClientIsUpToDate) {
   scoped_ptr<content::WebContents> web_contents2(
       content::WebContentsTester::CreateTestWebContents(browser_context(),
                                                         nullptr));
+  web_contents2->GetRenderViewHost()->GetProcess()->Init();

[ncarter (slow), 2015/05/29 17:31:31]

Same question here.

[nasko, 2015/06/01 19:00:09]

Done.

   content::RenderViewHostTester::For(web_contents2->GetRenderViewHost())
       ->CreateRenderView(base::string16(), MSG_ROUTING_NONE, MSG_ROUTING_NONE,
                          -1, false);