Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 1159183002: Improve process crash handling in RenderViewHost & mock RenderProcessHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix for WebViewInteractiveUiTest.TextInputClientIsUpToDate Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index d6abcbbfa10a5605dedbdb59b600fba978dad436..7bf9a744e0d450b1778af4f431f1b15120034e5f 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -654,7 +654,7 @@ bool RenderFrameHostImpl::IsRenderFrameLive() {
is_live = render_view_host_->IsRenderViewLive();
// Sanity check: the RenderView should always be live if the RenderFrame is.
- DCHECK(!is_live || render_view_host_->IsRenderViewLive());
+ DCHECK_IMPLIES(is_live, render_view_host_->IsRenderViewLive());
return is_live;
}
@@ -1107,16 +1107,6 @@ void RenderFrameHostImpl::OnRenderProcessGone(int status, int exit_code) {
iter.second.Run(ui::AXTreeUpdate());
ax_tree_snapshot_callbacks_.clear();
- if (frame_tree_node_->IsMainFrame()) {
- // RenderViewHost/RenderWidgetHost needs to reset some stuff.
- render_view_host_->RendererExited(
- render_view_host_->render_view_termination_status_, exit_code);
-
- render_view_host_->delegate_->RenderViewTerminated(
- render_view_host_, static_cast<base::TerminationStatus>(status),
- exit_code);
- }
-
// Note: don't add any more code at this point in the function because
// |this| may be deleted. Any additional cleanup should happen before
// the last block of code here.

Powered by Google App Engine
This is Rietveld 408576698