Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1205)

Unified Diff: content/browser/frame_host/frame_tree_unittest.cc

Issue 1159143008: Fix wrong initialization of renderer_initiated_creation parameter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixing after rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/frame_tree_unittest.cc
diff --git a/content/browser/frame_host/frame_tree_unittest.cc b/content/browser/frame_host/frame_tree_unittest.cc
index d74d97c0a40ba1bf1d493cb72b6410cfe09e0a83..9b538c7fdb9698f8d328974950b66f347aa70a49 100644
--- a/content/browser/frame_host/frame_tree_unittest.cc
+++ b/content/browser/frame_host/frame_tree_unittest.cc
@@ -232,6 +232,11 @@ TEST_F(FrameTreeTest, FindFrames) {
// Add a few child frames to the main frame.
FrameTree* frame_tree = contents()->GetFrameTree();
FrameTreeNode* root = frame_tree->root();
+
+ test_rvh()->CreateRenderView(base::string16(), MSG_ROUTING_NONE,
nasko 2015/06/05 21:23:43 nit: main_test_rfh()->InitializeRenderFrameIfNeede
+ MSG_ROUTING_NONE, -1, FrameReplicationState(),
+ false);
+
main_test_rfh()->OnCreateChildFrame(22, blink::WebTreeScopeType::Document,
"child0", blink::WebSandboxFlags::None);
main_test_rfh()->OnCreateChildFrame(23, blink::WebTreeScopeType::Document,
@@ -281,6 +286,9 @@ TEST_F(FrameTreeTest, PreviousSibling) {
// Add a few child frames to the main frame.
FrameTree* frame_tree = contents()->GetFrameTree();
FrameTreeNode* root = frame_tree->root();
+ test_rvh()->CreateRenderView(base::string16(), MSG_ROUTING_NONE,
+ MSG_ROUTING_NONE, -1, FrameReplicationState(),
+ false);
main_test_rfh()->OnCreateChildFrame(22, blink::WebTreeScopeType::Document,
"child0", blink::WebSandboxFlags::None);
main_test_rfh()->OnCreateChildFrame(23, blink::WebTreeScopeType::Document,
@@ -390,6 +398,10 @@ TEST_F(FrameTreeTest, ProcessCrashClearsGlobalMap) {
// Add a couple child frames to the main frame.
FrameTreeNode* root = contents()->GetFrameTree()->root();
+ test_rvh()->CreateRenderView(base::string16(), MSG_ROUTING_NONE,
+ MSG_ROUTING_NONE, -1, FrameReplicationState(),
+ false);
+
main_test_rfh()->OnCreateChildFrame(22, blink::WebTreeScopeType::Document,
std::string(),
blink::WebSandboxFlags::None);

Powered by Google App Engine
This is Rietveld 408576698