content/browser/frame_host/render_frame_host_impl.cc - Issue 1159143008: Fix wrong initialization of renderer_initiated_creation parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 1159143008: Fix wrong initialization of renderer_initiated_creation parameter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixing after rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/frame_tree_unittest.cc ('K') | « content/browser/frame_host/frame_tree_unittest.cc ('k') | content/browser/renderer_host/render_widget_host_impl.h » ('j') | content/test/web_contents_observer_sanity_checker.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.cc

diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc

index c8cc6470d22ab8354ec7efc73f3fe424d35e1d55..49d1454a82051b1a60d3600347403b030b267268 100644

--- a/content/browser/frame_host/render_frame_host_impl.cc

+++ b/content/browser/frame_host/render_frame_host_impl.cc

@@ -652,12 +652,6 @@ bool RenderFrameHostImpl::CreateRenderFrame(int parent_routing_id,

bool RenderFrameHostImpl::IsRenderFrameLive() {

bool is_live = GetProcess()->HasConnection() && render_frame_created_;

- // If the process is for an isolated guest (e.g. <webview>), rely on the

- // RenderViewHost liveness check. Once https://crbug.com/492830 is fixed,

- // this can be removed.

- if (GetProcess()->IsIsolatedGuest())

- is_live = render_view_host_->IsRenderViewLive();

// Sanity check: the RenderView should always be live if the RenderFrame is.

DCHECK_IMPLIES(is_live, render_view_host_->IsRenderViewLive());