Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1898)

Unified Diff: chrome/browser/background/background_contents.cc

Issue 1159143008: Fix wrong initialization of renderer_initiated_creation parameter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixing after rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/background/background_contents.cc
diff --git a/chrome/browser/background/background_contents.cc b/chrome/browser/background/background_contents.cc
index 258faf3c4eb6ff3bd28d3ac2a147f9c6c4e4bf75..6b02c78a44190ef227f0d969f3f2cacd2514b52f 100644
--- a/chrome/browser/background/background_contents.cc
+++ b/chrome/browser/background/background_contents.cc
@@ -44,7 +44,7 @@ BackgroundContents::BackgroundContents(
WebContents::CreateParams create_params(profile_, site_instance);
create_params.routing_id = routing_id;
create_params.main_frame_routing_id = main_frame_routing_id;
- create_params.renderer_initiated_creation = true;
+ create_params.renderer_initiated_creation = routing_id != MSG_ROUTING_NONE;
ncarter (slow) 2015/06/05 21:47:50 What are the (non-test) implications of this fix?
lfg 2015/06/05 22:07:06 In practice, the only issue is that we call the Re
ncarter (slow) 2015/06/05 22:12:08 Thanks for clarifying. Please update the commit me
if (session_storage_namespace) {
content::SessionStorageNamespaceMap session_storage_namespace_map;
session_storage_namespace_map.insert(

Powered by Google App Engine
This is Rietveld 408576698