chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc - Issue 1159143008: Fix wrong initialization of renderer_initiated_creation parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc

Issue 1159143008: Fix wrong initialization of renderer_initiated_creation parameter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixing after rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/background/background_contents.cc ('K') | « chrome/browser/background/background_contents.cc ('k') | chrome/browser/extensions/api/web_navigation/frame_navigation_state_unittest.cc » ('j') | content/browser/frame_host/frame_tree_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc

diff --git a/chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc b/chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc

index ce0c9c755cf48f4c2b7b64af1cfaca3f63a23740..e4dfc4c6efbeda88dc1cba7e93b4dc27a138e5e7 100644

--- a/chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc

+++ b/chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc

@@ -76,6 +76,12 @@ class CaptivePortalTabHelperTest : public ChromeRenderViewHostTestHarness {

ChromeRenderViewHostTestHarness::SetUp();

web_contents1_.reset(CreateTestWebContents());

web_contents2_.reset(CreateTestWebContents());

+ content::RenderViewHostTester::For(render_view_host1())

+ ->CreateTestRenderView(base::string16(), MSG_ROUTING_NONE,

+ MSG_ROUTING_NONE, -1, false);

+ content::RenderViewHostTester::For(render_view_host2())

+ ->CreateTestRenderView(base::string16(), MSG_ROUTING_NONE,

+ MSG_ROUTING_NONE, -1, false);

}

void TearDown() override {