Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1159123002: Revert of Clean up aligned allocation code in preparation for SIMD alignments. (Closed)

Created:
5 years, 6 months ago by bbudge
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Clean up aligned allocation code in preparation for SIMD alignments. (patchset #14 id:300001 of https://codereview.chromium.org/1150593003/) Reason for revert: Breaks mjsunit, webkit, mozilla, benchmarks. TBR=hpayer@chromium.org Original issue's description: > Clean up aligned allocation code in preparation for SIMD alignments. > > Moves alignment fill calculations into two static Heap methods. > Adds a Heap method to handle the complex case where filler is potentially needed before and after a heap object. > Makes DoubleAlignForDeserialization explicitly fill after an already > aligned object. > > LOG=N > BUG=v8:4124 > > Committed: https://crrev.com/fcfb080eb9a637f0ae066bed4c45095e60df8a84 > Cr-Commit-Position: refs/heads/master@{#28687} TBR=hpayer@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4124 Committed: https://crrev.com/3ee926e2a6a973712022bc023f0f8129f3fd1f06 Cr-Commit-Position: refs/heads/master@{#28688}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -253 lines) Patch
M src/heap/heap.h View 1 chunk +7 lines, -17 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +21 lines, -44 lines 0 comments Download
M src/heap/spaces.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/heap/spaces.cc View 1 chunk +14 lines, -9 lines 0 comments Download
M src/heap/spaces-inl.h View 4 chunks +43 lines, -27 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +0 lines, -152 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
bbudge
Created Revert of Clean up aligned allocation code in preparation for SIMD alignments.
5 years, 6 months ago (2015-05-28 17:57:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159123002/1
5 years, 6 months ago (2015-05-28 17:57:20 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 6 months ago (2015-05-28 17:57:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159123002/1
5 years, 6 months ago (2015-05-28 18:07:10 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 6 months ago (2015-05-28 18:07:12 UTC) #8
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-05-28 18:17:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159123002/1
5 years, 6 months ago (2015-05-28 18:17:35 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-05-28 18:17:50 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-05-28 18:19:16 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ee926e2a6a973712022bc023f0f8129f3fd1f06
Cr-Commit-Position: refs/heads/master@{#28688}

Powered by Google App Engine
This is Rietveld 408576698