[S.P.] Include selection rect in list marker cull rect when needed

[S.P.] Include selection rect in list marker cull rect when needed

TEST=fast/backgrounds/selection-background-color-of-image-list-style.html
TEST=fast/lists/markers-in-selection.html
BUG=496318
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196565

[fs, 2015-06-04 15:24:00]

fs@opera.com changed reviewers:
+ chrishtr@chromium.org

[chrishtr, 2015-06-04 18:13:22]

https://codereview.chromium.org/1159033010/diff/1/Source/core/paint/ListMarke...
File Source/core/paint/ListMarkerPainter.cpp (right):

https://codereview.chromium.org/1159033010/diff/1/Source/core/paint/ListMarke...
Source/core/paint/ListMarkerPainter.cpp:31:
overflowRect.unite(m_layoutListMarker.localSelectionRect());
I wonder if the other classes that have a special localSelectionRect will need
this code. In particular, LayoutReplaced, LayoutText, InlineTextBox and
SVGInlineTextBox.

[chrishtr, 2015-06-04 18:13:24]

lgtm

[fs, 2015-06-05 08:56:19]

https://codereview.chromium.org/1159033010/diff/1/Source/core/paint/ListMarke...
File Source/core/paint/ListMarkerPainter.cpp (right):

https://codereview.chromium.org/1159033010/diff/1/Source/core/paint/ListMarke...
Source/core/paint/ListMarkerPainter.cpp:31:
overflowRect.unite(m_layoutListMarker.localSelectionRect());
On 2015/06/04 18:13:22, chrishtr wrote:
> I wonder if the other classes that have a special localSelectionRect will need
> this code. In particular, LayoutReplaced, LayoutText, InlineTextBox and
> SVGInlineTextBox.

Most likely - I added one for InlineTextBox last week or so ago; LayoutReplaced
seems covered (ReplacedPainter, PartPainter); LayoutText doesn't have any AFAICS
(and I wouldn't expect it to), which leaves SVGInlineTextBox (where this method
can be pretty expensive =/).

[fs, 2015-06-05 08:56:23]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2015-06-05 08:56:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1159033010/1

[commit-bot: I haz the power, 2015-06-05 08:59:37]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196565