[S.P.] Include selection rect in list marker cull rect when needed

Source/core/paint/ListMarkerPainter.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/paint/ListMarkerPainter.h"
 
 #include "core/layout/LayoutListItem.h"
 #include "core/layout/LayoutListMarker.h"
 #include "core/layout/TextRunConstructor.h"
 #include "core/paint/BlockPainter.h"
 #include "core/paint/LayoutObjectDrawingRecorder.h"
 #include "core/paint/PaintInfo.h"
 #include "platform/geometry/LayoutPoint.h"
 #include "platform/graphics/GraphicsContextStateSaver.h"
 #include "wtf/unicode/CharacterNames.h"
 
 namespace blink {
 
 void ListMarkerPainter::paint(const PaintInfo& paintInfo, const LayoutPoint& paintOffset)
 {
     if (paintInfo.phase != PaintPhaseForeground)
         return;
 
     if (m_layoutListMarker.style()->visibility() != VISIBLE)
         return;
 
     LayoutPoint boxOrigin(paintOffset + m_layoutListMarker.location());
     LayoutRect overflowRect(m_layoutListMarker.visualOverflowRect());
+    if (m_layoutListMarker.selectionState() != LayoutObject::SelectionNone)
+        overflowRect.unite(m_layoutListMarker.localSelectionRect());

[chrishtr, 2015/06/04 18:13:22]

I wonder if the other classes that have a special localSelectionRect will need
this code. In particular, LayoutReplaced, LayoutText, InlineTextBox and
SVGInlineTextBox.

[fs, 2015/06/05 08:56:19]

Most likely - I added one for InlineTextBox last week or so ago; LayoutReplaced
seems covered (ReplacedPainter, PartPainter); LayoutText doesn't have any AFAICS
(and I wouldn't expect it to), which leaves SVGInlineTextBox (where this method
can be pretty expensive =/).

     overflowRect.moveBy(boxOrigin);
 
     IntRect pixelSnappedOverflowRect = pixelSnappedIntRect(overflowRect);
     if (!paintInfo.rect.intersects(pixelSnappedOverflowRect))
         return;
 
     LayoutObjectDrawingRecorder recorder(*paintInfo.context, m_layoutListMarker, paintInfo.phase, pixelSnappedOverflowRect);
     if (recorder.canUseCachedDrawing())
         return;
 
@@ skipping 168 matching lines @@
             context->drawText(font, textRunPaintInfo, textOrigin);
             context->drawText(font, suffixRunInfo, textOrigin + IntSize(font.width(textRun), 0));
         } else {
             context->drawText(font, suffixRunInfo, textOrigin);
             context->drawText(font, textRunPaintInfo, textOrigin + IntSize(font.width(suffixRun), 0));
         }
     }
 }
 
 } // namespace blink