ui/views/cocoa/bridged_native_widget.mm - Issue 1159033008: Refactor ViewsDelegate singleton

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/cocoa/bridged_native_widget.mm

Issue 1159033008: Refactor ViewsDelegate singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed review comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/cocoa/bridged_native_widget.mm

diff --git a/ui/views/cocoa/bridged_native_widget.mm b/ui/views/cocoa/bridged_native_widget.mm

index 78abdb837c97ba5c25f94525c20d25606e7990a9..2c831036b13c9cfe1b49abae58b250158ef5c0ed 100644

--- a/ui/views/cocoa/bridged_native_widget.mm

+++ b/ui/views/cocoa/bridged_native_widget.mm

@@ -777,10 +777,10 @@ gfx::Size BridgedNativeWidget::GetClientAreaSize() const {

void BridgedNativeWidget::CreateCompositor() {

DCHECK(!compositor_);

DCHECK(!compositor_widget_);

- DCHECK(ViewsDelegate::views_delegate);

+ DCHECK(ViewsDelegate::GetInstance());

ui::ContextFactory* context_factory =

- ViewsDelegate::views_delegate->GetContextFactory();

+ ViewsDelegate::GetInstance()->GetContextFactory();

DCHECK(context_factory);

AddCompositorSuperview();