Issue 1159013006: Revert of add asserts around results from requestLock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1159013006: Revert of add asserts around results from requestLock (Closed)

Created:
5 years, 6 months ago by reed1

Modified:
5 years, 6 months ago

Reviewers:
scroggo

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of add asserts around results from requestLock (patchset #3 id:40001 of https://codereview.chromium.org/1155403003/) Reason for revert: asserts in ui/gfx unittests (need to investigate why) [ RUN ] RenderTextTest.SelectionKeepsLigatures [14602:14602:0529/134016:16779526944:INFO:SkPixelRef.cpp(164)] ../../third_party/skia/src/core/SkPixelRef.cpp:164: failed assertion "pixels" Original issue's description: > add asserts around results from requestLock and lockPixels, ensuring that true always means we have non-null pixels (and non-null colortable if that matches the colortype) > > BUG=491975 > TBR= > > Committed: https://skia.googlesource.com/skia/+/f941a68126d8fe647eaea902c244c466568b7809 TBR=scroggo@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=491975 Committed: https://skia.googlesource.com/skia/+/3953d360417655b8000df0951699121383db45c3

Created: 5 years, 6 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -50 lines)			Patch
	M	include/core/SkPixelRef.h	View		3 chunks	+2 lines, -6 lines	0 comments	Download
	M	src/core/SkPixelRef.cpp	View		5 chunks	+32 lines, -44 lines	0 comments	Download

Total messages: 3 (0 generated)

reed1

Created Revert of add asserts around results from requestLock

5 years, 6 months ago (2015-05-29 21:21:28 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159013006/1

5 years, 6 months ago (2015-05-29 21:21:55 UTC) #2

commit-bot: I haz the power

5 years, 6 months ago (2015-05-29 21:22:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3953d360417655b8000df0951699121383db45c3