If javascript: returns no result, balance load progress notifications.

If javascript: returns no result, balance load progress notifications.

Upon executing a javascript: URL in an empty document, we take care to
notify that the load has started. Should the result of executing the
script code be no result and navigation, balance the progress notifications
by signalling completion also.

R=haraken
BUG=495495
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201481

[sof, 2015-06-02 08:22:37]

sigbjornf@opera.com changed reviewers:
+ dcheng@chromium.org, haraken@chromium.org

[sof, 2015-06-02 08:22:37]

please take a look.

i failed to come up with a layout/unit test that checks not-loading status, but
balancing the progress notifications here is straightforward.

[haraken, 2015-06-02 08:30:04]

LGTM

[sof, 2015-06-02 09:03:21]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2015-06-02 09:03:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158973004/20001

[sof, 2015-06-02 10:38:56]

The CQ bit was unchecked by sigbjornf@opera.com

[sof, 2015-06-02 10:41:36]

unchecked commit; triggers a progressCompleted() assert on
http/tests/navigation/back-to-dynamic-iframe.html

[sof, 2015-06-02 15:15:03]

On 2015/06/02 10:41:36, sof wrote:
> unchecked commit; triggers a progressCompleted() assert on
> http/tests/navigation/back-to-dynamic-iframe.html

Touches on load completion changes in r188082 (
http://src.chromium.org/viewvc/blink?view=rev&rev=188082 ) and r174324 (
http://src.chromium.org/viewvc/blink?view=rev&rev=174324 )

[sof, 2015-06-02 15:23:54]

+Cc: japhet

I don't have a good grasp of the load completion machinery, and
responsibilities, but adding local isLoading() checks around calls to signal
progress tracker completion would not be it.

[sof, 2015-08-28 13:44:48]

Finally had a look at this one again, addressing the single layout test failure
in ps#2. ptal?

A test case for this never-stops-loading case would be

 <a href="javascript:window.open('javascript:1')">click</a>

but I've completely failed to encode that as a WebFrameTest unit test.

[sof, 2015-08-31 10:09:08]

Unit test added also, looks acceptable?

[haraken, 2015-08-31 10:28:49]

LGTM

[sof, 2015-08-31 11:37:32]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2015-08-31 11:37:32]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1158973004/#ps80001
(title: "fix component building")

[commit-bot: I haz the power, 2015-08-31 11:37:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158973004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1158973004/80001

[commit-bot: I haz the power, 2015-08-31 12:46:00]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201481