Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Side by Side Diff: Source/web/tests/WebViewTest.cpp

Issue 1158973004: If javascript: returns no result, balance load progress notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix component building Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/core/v8/ScriptController.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 13 matching lines...) Expand all
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #include "config.h" 31 #include "config.h"
32 #include "public/web/WebView.h" 32 #include "public/web/WebView.h"
33 33
34 #include "bindings/core/v8/V8Document.h"
34 #include "core/dom/Document.h" 35 #include "core/dom/Document.h"
35 #include "core/dom/Element.h" 36 #include "core/dom/Element.h"
36 #include "core/editing/FrameSelection.h" 37 #include "core/editing/FrameSelection.h"
37 #include "core/frame/EventHandlerRegistry.h" 38 #include "core/frame/EventHandlerRegistry.h"
38 #include "core/frame/FrameHost.h" 39 #include "core/frame/FrameHost.h"
39 #include "core/frame/FrameView.h" 40 #include "core/frame/FrameView.h"
40 #include "core/frame/LocalFrame.h" 41 #include "core/frame/LocalFrame.h"
41 #include "core/frame/Settings.h" 42 #include "core/frame/Settings.h"
42 #include "core/frame/VisualViewport.h" 43 #include "core/frame/VisualViewport.h"
43 #include "core/html/HTMLDocument.h" 44 #include "core/html/HTMLDocument.h"
(...skipping 3000 matching lines...) Expand 10 before | Expand all | Expand 10 after
3044 ASSERT_EQ(4ul, renders.size()); 3045 ASSERT_EQ(4ul, renders.size());
3045 for (size_t i = 0; i < renders.size(); ++i) { 3046 for (size_t i = 0; i < renders.size(); ++i) {
3046 double docStartTime = frame->domWindow()->document()->loader()->timing() .monotonicTimeToZeroBasedDocumentTime(renderPairs[i].startTime) * 1000.0; 3047 double docStartTime = frame->domWindow()->document()->loader()->timing() .monotonicTimeToZeroBasedDocumentTime(renderPairs[i].startTime) * 1000.0;
3047 ASSERT_DOUBLE_EQ(docStartTime, renders[i]->startTime()); 3048 ASSERT_DOUBLE_EQ(docStartTime, renders[i]->startTime());
3048 double docFinishTime = frame->domWindow()->document()->loader()->timing( ).monotonicTimeToZeroBasedDocumentTime(renderPairs[i].finishTime) * 1000.0; 3049 double docFinishTime = frame->domWindow()->document()->loader()->timing( ).monotonicTimeToZeroBasedDocumentTime(renderPairs[i].finishTime) * 1000.0;
3049 double docDuration = docFinishTime - docStartTime; 3050 double docDuration = docFinishTime - docStartTime;
3050 ASSERT_DOUBLE_EQ(docDuration, renders[i]->duration()); 3051 ASSERT_DOUBLE_EQ(docDuration, renders[i]->duration());
3051 } 3052 }
3052 } 3053 }
3053 3054
3055
3056 TEST_F(WebViewTest, StopLoadingIfJavaScriptURLReturnsNoStringResult)
3057 {
3058 ViewCreatingWebViewClient client;
3059 FrameTestHelpers::WebViewHelper mainWebView;
3060 mainWebView.initializeAndLoad("about:blank", true, 0, &client);
3061 mainWebView.webViewImpl()->page()->settings().setJavaScriptCanOpenWindowsAut omatically(true);
3062
3063 WebFrame* frame = mainWebView.webView()->mainFrame();
3064 v8::HandleScope scope(v8::Isolate::GetCurrent());
3065 v8::Local<v8::Value> v8Value = frame->executeScriptAndReturnValue(WebScriptS ource("var win = window.open('javascript:false'); win.document"));
3066 ASSERT_TRUE(v8Value->IsObject());
3067 Document* document = V8Document::toImplWithTypeCheck(v8::Isolate::GetCurrent (), v8Value);
3068 ASSERT_TRUE(document);
3069 EXPECT_FALSE(document->frame()->isLoading());
3070 }
3071
3054 } // namespace blink 3072 } // namespace blink
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/ScriptController.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698