Add caps overrides to GMs

Add caps overrides to GMs

Committed: https://skia.googlesource.com/skia/+/4ee6bd86c500d9b464e2f8cb3565544b8c97c0a9

[bsalomon, 2015-05-27 16:31:26]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[bsalomon, 2015-05-27 16:52:19]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-05-27 16:52:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158963002/60001

[commit-bot: I haz the power, 2015-05-27 16:58:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-27 16:58:02]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2015-05-27 18:28:31]

lgtm + questions

https://codereview.chromium.org/1158963002/diff/60001/dm/DMGpuSupport.h
File dm/DMGpuSupport.h (right):

https://codereview.chromium.org/1158963002/diff/60001/dm/DMGpuSupport.h#newco...
dm/DMGpuSupport.h:57: 
What's up with the "{}" ?

https://codereview.chromium.org/1158963002/diff/60001/dm/DMSrcSink.cpp
File dm/DMSrcSink.cpp (right):

https://codereview.chromium.org/1158963002/diff/60001/dm/DMSrcSink.cpp#newcode59
dm/DMSrcSink.cpp:59: 
Would getGrContextOptions make more sense ?

https://codereview.chromium.org/1158963002/diff/60001/dm/DMSrcSink.cpp#newcode61
dm/DMSrcSink.cpp:61: SkAutoTDelete<skiagm::GM> gm(fFactory(NULL));
return of void ?

https://codereview.chromium.org/1158963002/diff/60001/gm/bleed.cpp
File gm/bleed.cpp (right):

https://codereview.chromium.org/1158963002/diff/60001/gm/bleed.cpp#newcode191
gm/bleed.cpp:191: 
Could make this two loops. One over bleed/no-bleed and the other over filter
mode.

[Chris Dalton, 2015-05-27 19:57:12]

cdalton@nvidia.com changed reviewers:
+ cdalton@nvidia.com

[Chris Dalton, 2015-05-27 19:57:13]

https://codereview.chromium.org/1158963002/diff/60001/src/gpu/GrCaps.cpp
File src/gpu/GrCaps.cpp (right):

https://codereview.chromium.org/1158963002/diff/60001/src/gpu/GrCaps.cpp#newc...
src/gpu/GrCaps.cpp:106: void GrCaps::applyOptionsOverrides(const
GrContextOptions& options) {
Do we want a similar method on the shader caps, or is the idea to override
shader caps in this function as well?

[bsalomon, 2015-05-27 20:17:33]

https://codereview.chromium.org/1158963002/diff/60001/dm/DMGpuSupport.h
File dm/DMGpuSupport.h (right):

https://codereview.chromium.org/1158963002/diff/60001/dm/DMGpuSupport.h#newco...
dm/DMGpuSupport.h:57: 
On 2015/05/27 18:28:31, robertphillips wrote:
> What's up with the "{}" ?

Some part of DM needed this defined and not just declared (this is in the no-gpu
section of this file that stubs out gpu stuff).

https://codereview.chromium.org/1158963002/diff/60001/dm/DMSrcSink.cpp
File dm/DMSrcSink.cpp (right):

https://codereview.chromium.org/1158963002/diff/60001/dm/DMSrcSink.cpp#newcode59
dm/DMSrcSink.cpp:59: 
On 2015/05/27 18:28:31, robertphillips wrote:
> Would getGrContextOptions make more sense ?

Maybe modify is more accurate, since it is in/out.

https://codereview.chromium.org/1158963002/diff/60001/dm/DMSrcSink.cpp#newcode61
dm/DMSrcSink.cpp:61: SkAutoTDelete<skiagm::GM> gm(fFactory(NULL));
On 2015/05/27 18:28:31, robertphillips wrote:
> return of void ?

Done.

https://codereview.chromium.org/1158963002/diff/60001/gm/bleed.cpp
File gm/bleed.cpp (right):

https://codereview.chromium.org/1158963002/diff/60001/gm/bleed.cpp#newcode191
gm/bleed.cpp:191: 
On 2015/05/27 18:28:31, robertphillips wrote:
> Could make this two loops. One over bleed/no-bleed and the other over filter
> mode.

I appreciated that this GM computed it's own dimensions (as statics). I suppose
that could be replicated with the loops, but I'm just going to leave as is for
now.

https://codereview.chromium.org/1158963002/diff/60001/src/gpu/GrCaps.cpp
File src/gpu/GrCaps.cpp (right):

https://codereview.chromium.org/1158963002/diff/60001/src/gpu/GrCaps.cpp#newc...
src/gpu/GrCaps.cpp:106: void GrCaps::applyOptionsOverrides(const
GrContextOptions& options) {
On 2015/05/27 19:57:13, Chris Dalton wrote:
> Do we want a similar method on the shader caps, or is the idea to override
> shader caps in this function as well?

I think we'd do it here as well. I added a stub function to GrShaderCaps to
apply overrides. It doesn't do anything currently.

[bsalomon, 2015-05-27 20:17:38]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-05-27 20:17:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1158963002/#ps80001
(title: "Address comments")

[commit-bot: I haz the power, 2015-05-27 20:17:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158963002/80001

[commit-bot: I haz the power, 2015-05-27 20:23:27]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/4ee6bd86c500d9b464e2f8cb3565544b8c97c0a9