Add support to mime types in Files app UI.

Add support to mime types in Files app UI.

Before, file icons and types were only based on file extensions, without using
mime types.

This CL makes the FileTask.xxx methods use the optionally passed mime type,
which is used with priority. If not available, or not matching, then it
falls back to the file extension based solution.

Since now contentMimeType is requested for all files on the file list, one
change has been made. The call to chrome.fileManagerPrivate.getMimeType has
been removed from FileSystemMetadataProvider, as it's slow (may sniff).

Since now, contentMimeType is only fetched via getEntryProperties() private
API, and it never sniffs. So it's a best effort method.

TEST=1. Opened a video file with no extension from Downloads,
     2. Images without extension show a correct icon on Drive (not Downloads).
BUG=446435
Committed: https://crrev.com/1143f7a9f3ada056c5ce7059a553dc6ec18f654f
Cr-Commit-Position: refs/heads/master@{#332792}

[mtomasz, 2015-06-03 10:45:43]

This basically works, but audio player and video player have to be fixed.

[mtomasz, 2015-06-03 10:57:35]

mtomasz@chromium.org changed reviewers:
+ yawano@chromium.org

[mtomasz, 2015-06-03 10:57:46]

@yawano: PTAL. Thanks!

[yawano, 2015-06-03 11:59:09]

https://codereview.chromium.org/1158923004/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/common/js/file_type.js (right):

https://codereview.chromium.org/1158923004/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/common/js/file_type.js:90: mimePattern:
/video\/3gpp/i
nit: 3gpp -> 3gp.

https://codereview.chromium.org/1158923004/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/common/js/file_type.js:245: mimePattern: new
RegExp('/application\/(vnd.ms-powerpoint|.openxmlformats' +
nit: vnd.ms-... -> vnd\.ms-...

Same for .openxmlformats?

https://codereview.chromium.org/1158923004/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/common/js/file_type.js:251: mimePattern: new
RegExp('/application\/(vnd.ms-excel|.openxmlformats\-/' +
nit: Same as above. vnd.ms-... -> vnd\.ms-...

https://codereview.chromium.org/1158923004/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/common/js/file_type.js:400: * @param {string=}
opt_mimeType Optional mime type for the file.
Optional parameter should be the last parameter.

https://codereview.chromium.org/1158923004/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/task_controller.js (right):

https://codereview.chromium.org/1158923004/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/task_controller.js:264: return new
Promise(function(fulfill, reject) {
Does this work correctly for files on Drive? This does not use the mime type
which is returned from the server.

[mtomasz, 2015-06-04 02:52:27]

https://codereview.chromium.org/1158923004/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/common/js/file_type.js (right):

https://codereview.chromium.org/1158923004/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/common/js/file_type.js:90: mimePattern:
/video\/3gpp/i
On 2015/06/03 11:59:09, yawano wrote:
> nit: 3gpp -> 3gp.

According to http://tools.ietf.org/html/rfc3839, it should be 3gpp.

https://codereview.chromium.org/1158923004/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/common/js/file_type.js:245: mimePattern: new
RegExp('/application\/(vnd.ms-powerpoint|.openxmlformats' +
On 2015/06/03 11:59:09, yawano wrote:
> nit: vnd.ms-... -> vnd\.ms-...
> 
> Same for .openxmlformats? 

Done.

https://codereview.chromium.org/1158923004/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/common/js/file_type.js:251: mimePattern: new
RegExp('/application\/(vnd.ms-excel|.openxmlformats\-/' +
On 2015/06/03 11:59:09, yawano wrote:
> nit: Same as above. vnd.ms-... -> vnd\.ms-...

Done.

https://codereview.chromium.org/1158923004/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/common/js/file_type.js:400: * @param {string=}
opt_mimeType Optional mime type for the file.
On 2015/06/03 11:59:09, yawano wrote:
> Optional parameter should be the last parameter.

If we put it as the last, then the order is confusing. I fixed by putting
"types" first, and entry and opt_mimeType next to each other. Let me know if
it's OK.

https://codereview.chromium.org/1158923004/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/task_controller.js (right):

https://codereview.chromium.org/1158923004/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/task_controller.js:264: return new
Promise(function(fulfill, reject) {
On 2015/06/03 11:59:09, yawano wrote:
> Does this work correctly for files on Drive? This does not use the mime type
> which is returned from the server.

Good point. Let me revert this change.

[yawano, 2015-06-04 03:29:41]

lgtm!

https://codereview.chromium.org/1158923004/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/common/js/file_type.js (right):

https://codereview.chromium.org/1158923004/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/common/js/file_type.js:90: mimePattern:
/video\/3gpp/i
On 2015/06/04 02:52:27, mtomasz wrote:
> On 2015/06/03 11:59:09, yawano wrote:
> > nit: 3gpp -> 3gp.
> 
> According to http://tools.ietf.org/html/rfc3839, it should be 3gpp.

Acknowledged.

https://codereview.chromium.org/1158923004/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/common/js/file_type.js:400: * @param {string=}
opt_mimeType Optional mime type for the file.
SGTM.

[mtomasz, 2015-06-04 04:39:18]

@yawano: I made some more fixes to tests. PTAL. Thanks.

[yawano, 2015-06-04 04:47:47]

On 2015/06/04 04:39:18, mtomasz wrote:
> @yawano: I made some more fixes to tests. PTAL. Thanks.

still lgtm!

[mtomasz, 2015-06-04 06:42:37]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2015-06-04 06:42:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158923004/100001

[commit-bot: I haz the power, 2015-06-04 06:46:54]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-06-04 06:47:47]

Patchset 6 (id:??) landed as
https://crrev.com/1143f7a9f3ada056c5ce7059a553dc6ec18f654f
Cr-Commit-Position: refs/heads/master@{#332792}