ui/file_manager/file_manager/foreground/js/metadata/thumbnail_model.js - Issue 1158923004: Add support to mime types in Files app UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/metadata/thumbnail_model.js

Issue 1158923004: Add support to mime types in Files app UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed tests. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata_provider_unittest.js ('k') | ui/file_manager/file_manager/foreground/js/thumbnail_loader.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/js/metadata/thumbnail_model.js

diff --git a/ui/file_manager/file_manager/foreground/js/metadata/thumbnail_model.js b/ui/file_manager/file_manager/foreground/js/metadata/thumbnail_model.js

index bc6a6cc9a2375dc3a4db093864022918c9df7871..f8e0b3a401f9c2cb361e0cbc6ed77d310b1056f5 100644

--- a/ui/file_manager/file_manager/foreground/js/metadata/thumbnail_model.js

+++ b/ui/file_manager/file_manager/foreground/js/metadata/thumbnail_model.js

@@ -33,6 +33,7 @@ ThumbnailModel.prototype.get = function(entries) {

[

'modificationTime',

'customIconUrl',

+ 'contentMimeType',

'thumbnailUrl',

'croppedThumbnailUrl',

'present'

@@ -62,7 +63,8 @@ ThumbnailModel.prototype.get = function(entries) {

media: {}

};

var canUseContentThumbnail =

- metadataList[i].present && FileType.isImage(entries[i]);

+ metadataList[i].present &&

+ FileType.isImage(entries[i], metadataList[i].contentMimeType);

if (canUseContentThumbnail)

contentRequestEntries.push(entries[i]);

}