Remove support for the "gcm_user_visible_only" manifest key.

Remove support for the "gcm_user_visible_only" manifest key.

Per the following Intent to blink-dev, support for this manifest key has
been deprecated per Chrome 44, and will be removed in Chrome 45. We'd like
to do this early in the release cycle, allowing developers to catch on
early when they run the Dev channel.

https://groups.google.com/a/chromium.org/d/topic/blink-dev/6OK5qm491Eg/discussion

A screenshot of the console warning can be seen here:
  http://peter.sh/files/devtools-deprecation-message.jpg

BUG=471534
Committed: https://crrev.com/5531299a236b75e9973239e5785495d2024cb153
Cr-Commit-Position: refs/heads/master@{#332386}

[Peter Beverloo, 2015-05-27 12:56:25]

peter@chromium.org changed reviewers:
+ johnme@chromium.org

[Peter Beverloo, 2015-05-27 12:56:26]

+johnme, PTAL

[johnme, 2015-05-28 12:35:13]

lgtm with console warning

https://codereview.chromium.org/1158923002/diff/1/content/renderer/push_messa...
File content/renderer/push_messaging/push_messaging_dispatcher.cc (left):

https://codereview.chromium.org/1158923002/diff/1/content/renderer/push_messa...
content/renderer/push_messaging/push_messaging_dispatcher.cc:93:
render_frame()->GetWebFrame()->addMessageToConsole(message);
Please continue logging a warning, since developers are likely to ignore the
deprecation warning whilst things continue working, and only try to debug once
things have broken. Something like:

const char kUserVisibleWarning[] = "Chrome currently only allows push messages
that result in a user-visible notification. Websites must indicate their
understanding of this by calling pushManager.subscribe({userVisibleOnly: true}).
Without this permission will be denied. Note that previously a website could
pass a 'gcm_user_visible_only' manifest key; this was deprecated in Chrome 44
and removed in Chrome 45. See
https://docs.google.com/document/d/13VxFdLJbMwxHrvnpDm8RXnU41W2ZlcP0mdWWe9zXQ...
for more details.";

if (!options.userVisibleOnly) {
    log the warning
}

[mlamouri (slow - plz ping), 2015-05-29 13:25:03]

mlamouri@chromium.org changed reviewers:
+ mlamouri@chromium.org

[mlamouri (slow - plz ping), 2015-05-29 13:25:03]

Manifest bits lgtm.

Something should be done with gcm_sender_id. Per previous discussions, it
shouldn't live in the content/ layer because it is Chrome proprietary.

[Peter Beverloo, 2015-05-29 14:15:30]

peter@chromium.org changed reviewers:
+ avi@chromium.org, pfeldman@chromium.org

[Peter Beverloo, 2015-05-29 14:15:31]

Thank you John, Mounir. Mounir, would you mind filing an issue so that we track
this accordingly?

+avi for //content/public/
+pfeldman FYI since it uses the new RFH API.

https://codereview.chromium.org/1158923002/diff/1/content/renderer/push_messa...
File content/renderer/push_messaging/push_messaging_dispatcher.cc (left):

https://codereview.chromium.org/1158923002/diff/1/content/renderer/push_messa...
content/renderer/push_messaging/push_messaging_dispatcher.cc:93:
render_frame()->GetWebFrame()->addMessageToConsole(message);
On 2015/05/28 12:35:12, johnme wrote:
> Please continue logging a warning, since developers are likely to ignore the
> deprecation warning whilst things continue working, and only try to debug once
> things have broken. Something like:
> 
> const char kUserVisibleWarning[] = "Chrome currently only allows push messages
> that result in a user-visible notification. Websites must indicate their
> understanding of this by calling pushManager.subscribe({userVisibleOnly:
true}).
> Without this permission will be denied. Note that previously a website could
> pass a 'gcm_user_visible_only' manifest key; this was deprecated in Chrome 44
> and removed in Chrome 45. See
>
https://docs.google.com/document/d/13VxFdLJbMwxHrvnpDm8RXnU41W2ZlcP0mdWWe9zXQ...
> for more details.";
> 
> if (!options.userVisibleOnly) {
>     log the warning
> }

I agree with the warning, but we shouldn't have it here. Added it in
PushMessagingServiceImpl using a new RFH API I introduce here:

https://codereview.chromium.org/1154673005/

[Avi (use Gerrit), 2015-05-29 15:22:50]

content/public lgtm

[Peter Beverloo, 2015-06-02 14:21:56]

The CQ bit was checked by peter@chromium.org

[Peter Beverloo, 2015-06-02 14:21:56]

The patchset sent to the CQ was uploaded after l-g-t-m from johnme@chromium.org,
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/1158923002/#ps20001
(title: "Add a message")

[commit-bot: I haz the power, 2015-06-02 14:22:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158923002/20001

[commit-bot: I haz the power, 2015-06-02 15:06:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-02 15:07:18]

Patchset 2 (id:??) landed as
https://crrev.com/5531299a236b75e9973239e5785495d2024cb153
Cr-Commit-Position: refs/heads/master@{#332386}

[head06902, 2017-02-23 04:18:36]

head06902@gmail.com changed reviewers:
+ head06902@gmail.com

[head06902, 2017-02-23 04:22:51]

lgtm

[head06902, 2017-02-23 04:22:52]

lgtm

[head06902, 2017-02-23 04:22:53]

lgtm