Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Unified Diff: content/browser/push_messaging/push_messaging_message_filter.cc

Issue 1158923002: Remove support for the "gcm_user_visible_only" manifest key. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a message Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/push_messaging/push_messaging_message_filter.cc
diff --git a/content/browser/push_messaging/push_messaging_message_filter.cc b/content/browser/push_messaging/push_messaging_message_filter.cc
index e6a869b09ab36fbe5890ae77afc32eca15e20f54..836d83fbe121faa4631dfe3bcf6d131a0ac8eef6 100644
--- a/content/browser/push_messaging/push_messaging_message_filter.cc
+++ b/content/browser/push_messaging/push_messaging_message_filter.cc
@@ -217,7 +217,6 @@ void PushMessagingMessageFilter::OnSubscribeFromDocument(
int64_t service_worker_registration_id) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
// TODO(mvanouwerkerk): Validate arguments?
- // TODO(peter): Persist |user_visible| in Service Worker storage.
RegisterData data;
data.request_id = request_id;
data.service_worker_registration_id = service_worker_registration_id;
« no previous file with comments | « chrome/test/data/push_messaging/test_user_visible_only_manifest.html ('k') | content/public/common/manifest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698