third_party/libvpx/DEPS - Issue 1158913006: Move libvpx from DEPS to src

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/libvpx/DEPS

Issue 1158913006: Move libvpx from DEPS to src (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add DEPS file with #include paths Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 include_rules = [

	2 '+..',
	scottmg 2015/05/29 23:00:52 This seems weird, this generically allowing third_ This seems weird, this generically allowing third_party? Can't you just use third_party/whatever/ like other places do? Johann 2015/05/29 23:08:06 Some of our internal headers use relative paths: h Show quoted text On 2015/05/29 23:00:52, scottmg wrote: > This seems weird, this generically allowing third_party? Can't you just use > third_party/whatever/ like other places do? Some of our internal headers use relative paths: https://chromium.googlesource.com/webm/libvpx/+/master/vpx/internal/vpx_codec... And my understanding is that having this DEPS file in third_party/libvpx only allows these within this component of third_party, not throughout third_party.
	3 '+gtest',

	4 '+libyuv',
	scottmg 2015/05/29 23:00:52 is this third_party/libyuv or third_party/libvpx/. is this third_party/libyuv or third_party/libvpx/.../libyuv? (why do we have both?) Johann 2015/05/29 23:08:06 this refers to third_party/libvpx/source/libvpx/th Show quoted text On 2015/05/29 23:00:52, scottmg wrote: > is this third_party/libyuv or third_party/libvpx/.../libyuv? (why do we have > both?) this refers to third_party/libvpx/source/libvpx/third_party/libyuv: https://chromium.googlesource.com/webm/libvpx/+/master/third_party/libyuv/ It's used by the upstream project for the example code show the use of scaling. It's not actually built anywhere within src/third_party/libvpx/ (if the presubmit was limited to files in .gypi/.gn files, it wouldn't show up)
	5 '+test',

	6 '+vp8',

	7 '+vp9',

	8 '+vpx',

	9 '+vpx_mem',

	10 '+vpx_ports',

	11 '+vpx_scale',

	12 ]

OLD	NEW

« no previous file with comments | « third_party/libvpx/BUILD.gn ('k') | third_party/libvpx/OWNERS » ('j') | no next file with comments »