Move libvpx from DEPS to src

Move libvpx from DEPS to src

Remove WATCHLISTS and codereview.settings, use parent versions.

Add DEPS file to enumerate the #include paths.

Get source/libvpx from upstream project

This completely breaks the current updating procedure.

https://chromium.googlesource.com/chromium/deps/libvpx/+/a208ecae8e6fff1c0d4286bdc000d7c5efaab411

BUG=481034
R=iannucci,tomfinegan

[iannucci, 2015-05-29 00:54:43]

this lgtm from an infra PoV, though I don't know that I'm a very good reviewer
for this from a chromium/src-code-layout-and-decisions-PoV (if such a thing
needs review).

I'd probably PSA this to chromium-dev just to give people a heads-up. I'd
probably also recommend moving it out of third_party (because having
source-of-truth code in third_party seems really weird to me) in some subsequent
CL too, though I definitely don't know much about that :)

[Johann, 2015-05-29 22:39:02]

Woops, thought I responded but I guess not.

On 2015/05/29 00:54:43, iannucci wrote:
> this lgtm from an infra PoV, though I don't know that I'm a very good reviewer
> for this from a chromium/src-code-layout-and-decisions-PoV (if such a thing
> needs review).

I suppose this is an acceptable location because I have no idea where else to
put it. I'm certainly not breaking ground by having third_party code outside of
the DEPS thing. I have no idea who to ask to review this either.

> I'd probably PSA this to chromium-dev just to give people a heads-up. I'd
> probably also recommend moving it out of third_party (because having
> source-of-truth code in third_party seems really weird to me) in some
subsequent
> CL too, though I definitely don't know much about that :)

https://groups.google.com/a/chromium.org/d/msg/chromium-dev/5X8r5DjnAFk/WDE_F...

The source of truth is and will remain
https://chromium.googlesource.com/webm/libvpx/ - this is just a copy.

[scottmg, 2015-05-29 23:00:43]

scottmg@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2015-05-29 23:00:53]

https://codereview.chromium.org/1158913006/diff/20001/third_party/libvpx/DEPS
File third_party/libvpx/DEPS (right):

https://codereview.chromium.org/1158913006/diff/20001/third_party/libvpx/DEPS...
third_party/libvpx/DEPS:2: '+..',
This seems weird, this generically allowing third_party? Can't you just use
third_party/whatever/ like other places do?

https://codereview.chromium.org/1158913006/diff/20001/third_party/libvpx/DEPS...
third_party/libvpx/DEPS:4: '+libyuv',
is this third_party/libyuv or third_party/libvpx/.../libyuv? (why do we have
both?)

[Johann, 2015-05-29 23:08:06]

https://codereview.chromium.org/1158913006/diff/20001/third_party/libvpx/DEPS
File third_party/libvpx/DEPS (right):

https://codereview.chromium.org/1158913006/diff/20001/third_party/libvpx/DEPS...
third_party/libvpx/DEPS:2: '+..',
On 2015/05/29 23:00:52, scottmg wrote:
> This seems weird, this generically allowing third_party? Can't you just use
> third_party/whatever/ like other places do?

Some of our internal headers use relative paths:
https://chromium.googlesource.com/webm/libvpx/+/master/vpx/internal/vpx_codec...

And my understanding is that having this DEPS file in third_party/libvpx only
allows these within this component of third_party, not throughout third_party.

https://codereview.chromium.org/1158913006/diff/20001/third_party/libvpx/DEPS...
third_party/libvpx/DEPS:4: '+libyuv',
On 2015/05/29 23:00:52, scottmg wrote:
> is this third_party/libyuv or third_party/libvpx/.../libyuv? (why do we have
> both?)

this refers to third_party/libvpx/source/libvpx/third_party/libyuv:
https://chromium.googlesource.com/webm/libvpx/+/master/third_party/libyuv/

It's used by the upstream project for the example code show the use of scaling.
It's not actually built anywhere within src/third_party/libvpx/ (if the
presubmit was limited to files in .gypi/.gn files, it wouldn't show up)

[Johann, 2015-05-29 23:25:46]

johannkoenig@google.com changed reviewers:
+ tomfinegan@chromium.org

[Johann, 2015-06-01 17:21:00]

The CQ bit was checked by johannkoenig@google.com

[Johann, 2015-06-01 17:21:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/1158913006/#ps30001
(title: "rebase")

[commit-bot: I haz the power, 2015-06-01 17:22:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158913006/30001

[commit-bot: I haz the power, 2015-06-01 17:53:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-01 17:54:05]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Johann, 2015-06-01 18:01:32]

On 2015/06/01 17:54:05, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Not totally sure why this failed but I think I might need LGTM from Tom first?
He's OOO, so I'll try when he's back.

[Tom Finegan, 2015-06-02 17:16:16]

On 2015/06/01 18:01:32, Johann wrote:
> On 2015/06/01 17:54:05, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> 
> Not totally sure why this failed but I think I might need LGTM from Tom first?
> He's OOO, so I'll try when he's back.

Gotta love it when this happens:

"""
status: FAILURE
status reason: 
"""

Anyway, lgtm but not sure this will make any difference. Might need to ask
someone that's moved something from deps to src if they've seen it before...

[Johann, 2015-06-02 18:53:38]

The CQ bit was checked by johannkoenig@google.com

[commit-bot: I haz the power, 2015-06-02 18:57:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158913006/30001

[commit-bot: I haz the power, 2015-06-02 19:42:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-02 19:42:57]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Johann, 2015-09-03 03:03:37]

The CQ bit was checked by johannkoenig@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-03 03:03:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158913006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1158913006/60001

[commit-bot: I haz the power, 2015-09-03 03:15:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-03 03:15:31]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Johann, 2015-09-03 03:43:01]

The CQ bit was checked by johannkoenig@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-03 03:43:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158913006/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1158913006/70001

[commit-bot: I haz the power, 2015-09-03 04:07:06]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2015-09-03 04:07:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-03 04:07:48]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Johann, 2015-09-03 19:43:26]

The CQ bit was checked by johannkoenig@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-03 19:43:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158913006/90001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1158913006/90001

[commit-bot: I haz the power, 2015-09-03 19:47:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-03 19:47:43]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)