Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Issue 1158883005: Get test running scripts to detect and report common error, XFA. (Closed)

Created:
5 years, 6 months ago by brucedawson
Modified:
5 years, 6 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Get test running scripts to detect and report common error, XFA. testing/tools/run_corpus_tests.py assumes a debug build and will fail cryptically if only a release build is available. Arguably there shouldn't be a default because having one could lead to accidentally running a stale version, but that is probably too much of a change. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1150823003 Committed: https://pdfium.googlesource.com/pdfium/+/56ba4292f1454f259b52a68dd962cc2d8c2027c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M testing/tools/run_corpus_tests.py View 1 chunk +4 lines, -0 lines 0 comments Download
M testing/tools/run_javascript_tests.py View 1 chunk +4 lines, -0 lines 0 comments Download
M testing/tools/run_pixel_tests.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
brucedawson
5 years, 6 months ago (2015-06-01 21:53:08 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
56ba4292f1454f259b52a68dd962cc2d8c2027c8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698