Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1150823003: Get test running scripts to detect and report common error. (Closed)

Created:
5 years, 7 months ago by brucedawson
Modified:
5 years, 7 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Get test running scripts to detect and report common error. testing/tools/run_corpus_tests.py assumes a debug build and will fail cryptically if only a release build is available. Arguably there shouldn't be a default because having one could lead to accidentally running a stale version, but that is probably too much of a change. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/79569e74ddddb12b3a76d211d826be2a3d87d0d0

Patch Set 1 #

Total comments: 2

Patch Set 2 : Tweak fix to test code and apply to all three test runners. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M testing/tools/run_corpus_tests.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M testing/tools/run_javascript_tests.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M testing/tools/run_pixel_tests.py View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
brucedawson
I finally tried running the test scripts, and hit a cryptic failure. I figured it ...
5 years, 7 months ago (2015-05-20 22:59:19 UTC) #1
Tom Sepez
https://codereview.chromium.org/1150823003/diff/1/testing/tools/run_corpus_tests.py File testing/tools/run_corpus_tests.py (right): https://codereview.chromium.org/1150823003/diff/1/testing/tools/run_corpus_tests.py#newcode30 testing/tools/run_corpus_tests.py:30: if not os.path.exists(pdfium_test_path): This should move to line 49, ...
5 years, 7 months ago (2015-05-20 23:24:38 UTC) #2
brucedawson
Good points. Moved, text changed, and fix applied to all three test runners. PTAL.
5 years, 7 months ago (2015-05-20 23:30:34 UTC) #3
Tom Sepez
lgtm
5 years, 7 months ago (2015-05-20 23:45:58 UTC) #4
brucedawson
5 years, 7 months ago (2015-05-20 23:52:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
79569e74ddddb12b3a76d211d826be2a3d87d0d0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698