Use RenderFrameHost for ::RequestPermission() and ::CancelPermission().

Use RenderFrameHost for ::RequestPermission() and ::CancelPermission().

This is using RenderFrameHost instead of WebContents so it's possible
to know to associate a request and a frame. Each request will then be
defined by its process id, its frame id and its request id, making it
entirely unique.

BUG=491923
Committed: https://crrev.com/5fc460f2bd3055f9142567a7b6e12d1b9e17de3c
Cr-Commit-Position: refs/heads/master@{#332635}

[mlamouri (slow - plz ping), 2015-05-26 21:20:30]

mlamouri@chromium.org changed reviewers:
+ bauerb@chromium.org, jam@chromium.org

[mlamouri (slow - plz ping), 2015-05-26 21:20:31]

bauerb@ and jam@, can you both have a look at this please? :)

[mlamouri (slow - plz ping), 2015-05-26 21:21:07]

+ohm@opera.com FYI

[mlamouri (slow - plz ping), 2015-05-26 21:22:03]

This CL might be rough around the edges, I wrote that during might flight and I
will be OOO tomorrow so I wanted to make sure it's uploaded so you all can have
a chance to review/comment.

[Bernhard Bauer, 2015-05-27 08:26:40]

https://codereview.chromium.org/1158813002/diff/1/chrome/browser/content_sett...
File chrome/browser/content_settings/permission_queue_controller.cc (right):

https://codereview.chromium.org/1158813002/diff/1/chrome/browser/content_sett...
chrome/browser/content_settings/permission_queue_controller.cc:34:
content::WebContents* web_contents =  tab_util::GetWebContentsByFrameID(
Remove one space after the equals sign.

https://codereview.chromium.org/1158813002/diff/1/chrome/browser/geolocation/...
File chrome/browser/geolocation/geolocation_permission_context.cc (right):

https://codereview.chromium.org/1158813002/diff/1/chrome/browser/geolocation/...
chrome/browser/geolocation/geolocation_permission_context.cc:72: // WebContents
may have gone away (or not exists for extension).
Can you move this comment to the `if (content_settings)` check below (and maybe
make it syntactically correct)?

https://codereview.chromium.org/1158813002/diff/1/chrome/browser/geolocation/...
chrome/browser/geolocation/geolocation_permission_context.cc:74:
TabSpecificContentSettings::Get(content::RenderFrameHost::FromID(
What if RenderFrameHost::FromID returns null?

[Fredrik Öhrn, 2015-05-27 08:46:34]

On 2015/05/26 21:21:07, Mounir Lamouri wrote:
> mailto:+ohm@opera.com FYI

Thanks for the heads up. While this solution works, I do think making request_id
unique per WebContents makes the API much easier to use. That way the UI can
keep a simple "int -> permission dialog" mapping per tab. You guys already have
heavy machinery like PermissionRequestID and such but anyone building from
scratch on top of the content API would be well served by this.

If we keep the existing arguments to CancelPermissionRequest as is, it'll also
stay backwards compatible with your existing UI code and the cancellation bug
will be fixed with only a few lines changed in content.

[jam, 2015-05-27 17:26:21]

On 2015/05/26 21:20:31, Mounir Lamouri wrote:
> bauerb@ and jam@, can you both have a look at this please? :)

which parts do you want me to look at?

[mlamouri (slow - plz ping), 2015-05-30 13:31:06]

bauerb@, could you review the changes in:
  chrome/browser/content_settings/permission_context_base_unittest.cc
  chrome/browser/content_settings/permission_queue_controller.cc
  chrome/browser/content_settings/permission_queue_controller_unittest.cc
  chrome/browser/content_settings/tab_specific_content_settings.cc
  chrome/browser/content_settings/tab_specific_content_settings.h
  components/content_settings/core/common/permission_request_id.cc
  components/content_settings/core/common/permission_request_id.h

jam@, could you review everything else?

The meat of this change is in the files that bauerb@ has to review, the other
changes are mechanical changes required throughout the code base.

https://codereview.chromium.org/1158813002/diff/1/chrome/browser/content_sett...
File chrome/browser/content_settings/permission_queue_controller.cc (right):

https://codereview.chromium.org/1158813002/diff/1/chrome/browser/content_sett...
chrome/browser/content_settings/permission_queue_controller.cc:34:
content::WebContents* web_contents =  tab_util::GetWebContentsByFrameID(
On 2015/05/27 at 08:26:40, Bernhard Bauer wrote:
> Remove one space after the equals sign.

Done.

https://codereview.chromium.org/1158813002/diff/1/chrome/browser/geolocation/...
File chrome/browser/geolocation/geolocation_permission_context.cc (right):

https://codereview.chromium.org/1158813002/diff/1/chrome/browser/geolocation/...
chrome/browser/geolocation/geolocation_permission_context.cc:72: // WebContents
may have gone away (or not exists for extension).
On 2015/05/27 at 08:26:40, Bernhard Bauer wrote:
> Can you move this comment to the `if (content_settings)` check below (and
maybe make it syntactically correct)?

Done.

https://codereview.chromium.org/1158813002/diff/1/chrome/browser/geolocation/...
chrome/browser/geolocation/geolocation_permission_context.cc:74:
TabSpecificContentSettings::Get(content::RenderFrameHost::FromID(
On 2015/05/27 at 08:26:40, Bernhard Bauer wrote:
> What if RenderFrameHost::FromID returns null?

content_settings will be null.

[mlamouri (slow - plz ping), 2015-06-01 15:59:37]

mlamouri@chromium.org changed reviewers:
+ jochen@chromium.org, torne@chromium.org
- jam@chromium.org

[mlamouri (slow - plz ping), 2015-06-01 15:59:38]

Changing reviewers to have them in closer timezone:

bauerb@, could you look at:
 - chrome/browser/content_settings/
 - components/content_settings/

torne@, could you look at:
 - android_webview/

jochen@, could you look at:
 - chrome/
 - content/

[mlamouri (slow - plz ping), 2015-06-01 16:00:52]

mlamouri@chromium.org changed reviewers:
+ lcwu@chromium.org

[mlamouri (slow - plz ping), 2015-06-01 16:00:53]

lcwu@, could you look at:
 - chromecast/

[gunsch, 2015-06-01 16:04:05]

gunsch@chromium.org changed reviewers:
+ gunsch@chromium.org

[gunsch, 2015-06-01 16:04:06]

lcwu is ooo, rs lgtm for chromecast/

[Torne, 2015-06-01 16:04:13]

torne@chromium.org changed reviewers:
- gunsch@chromium.org

[gunsch, 2015-06-01 16:04:13]

gunsch@chromium.org changed reviewers:
- lcwu@chromium.org

[Torne, 2015-06-01 16:04:14]

android_webview LGTM

[Bernhard Bauer, 2015-06-01 16:11:41]

content_settings LGTM.

[mlamouri (slow - plz ping), 2015-06-02 12:42:00]

mlamouri@chromium.org changed reviewers:
+ gunsch@chromium.org
- lcwu@chromium.org

[mlamouri (slow - plz ping), 2015-06-02 12:42:23]

mlamouri@chromium.org changed required reviewers:
+ gunsch@chromium.org, jochen@chromium.org, torne@chromium.org

[jochen (gone - plz use gerrit), 2015-06-02 16:21:19]

lgtm

[mlamouri (slow - plz ping), 2015-06-02 16:22:11]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2015-06-02 16:22:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158813002/40001

[commit-bot: I haz the power, 2015-06-02 16:28:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-02 16:28:56]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mlamouri (slow - plz ping), 2015-06-02 16:45:34]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2015-06-02 16:45:35]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
jochen@chromium.org, torne@chromium.org, gunsch@chromium.org
Link to the patchset: https://codereview.chromium.org/1158813002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2015-06-02 16:46:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158813002/60001

[commit-bot: I haz the power, 2015-06-02 17:02:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-02 17:02:56]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[mlamouri (slow - plz ping), 2015-06-03 13:49:24]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2015-06-03 13:49:24]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
jochen@chromium.org, torne@chromium.org, gunsch@chromium.org
Link to the patchset: https://codereview.chromium.org/1158813002/#ps80001
(title: "build fixes")

[commit-bot: I haz the power, 2015-06-03 13:49:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158813002/80001

[commit-bot: I haz the power, 2015-06-03 17:30:38]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-06-03 17:31:25]

Patchset 5 (id:??) landed as
https://crrev.com/5fc460f2bd3055f9142567a7b6e12d1b9e17de3c
Cr-Commit-Position: refs/heads/master@{#332635}