Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: components/content_settings/core/common/permission_request_id.cc

Issue 1158813002: Use RenderFrameHost for ::RequestPermission() and ::CancelPermission(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: build fixes Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/content_settings/core/common/permission_request_id.cc
diff --git a/components/content_settings/core/common/permission_request_id.cc b/components/content_settings/core/common/permission_request_id.cc
index 0d963a4a752a923ccca26e617b12eefc9a9054cb..7d7eccbad794501052174e7da08c03e4d69d6ab3 100644
--- a/components/content_settings/core/common/permission_request_id.cc
+++ b/components/content_settings/core/common/permission_request_id.cc
@@ -7,11 +7,11 @@
#include "base/strings/stringprintf.h"
PermissionRequestID::PermissionRequestID(int render_process_id,
- int render_view_id,
+ int render_frame_id,
int bridge_id,
const GURL& origin)
: render_process_id_(render_process_id),
- render_view_id_(render_view_id),
+ render_frame_id_(render_frame_id),
bridge_id_(bridge_id),
origin_(origin) {
}
@@ -20,20 +20,16 @@ PermissionRequestID::~PermissionRequestID() {
}
bool PermissionRequestID::Equals(const PermissionRequestID& other) const {
- return IsForSameTabAs(other) && (bridge_id_ == other.bridge_id_) &&
- (origin_ == other.origin());
-}
-
-bool PermissionRequestID::IsForSameTabAs(
- const PermissionRequestID& other) const {
- return (render_process_id_ == other.render_process_id_) &&
- (render_view_id_ == other.render_view_id_);
+ return render_process_id_ == other.render_process_id_ &&
+ render_frame_id_ == other.render_frame_id_ &&
+ bridge_id_ == other.bridge_id_ &&
+ origin_ == other.origin_;
}
std::string PermissionRequestID::ToString() const {
return base::StringPrintf("%d,%d,%d,%s",
render_process_id_,
- render_view_id_,
+ render_frame_id_,
bridge_id_,
origin_.spec().c_str());
}

Powered by Google App Engine
This is Rietveld 408576698