Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 115873003: EventHandler getters return RefPtr<EventListener> (not v8::Handle<v8::Value>)

Created:
7 years ago by Nils Barth (inactive)
Modified:
7 years ago
Reviewers:
haraken
CC:
blink-reviews, kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive, kouhei (in TOK)
Visibility:
Public.

Description

EventHandler getters return RefPtr<EventListener> (not v8::Handle<v8::Value>) For consistency with other DOM objects, per request of haraken@ https://codereview.chromium.org/117063002/#msg7 R=haraken

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M Source/bindings/scripts/code_generator_v8.pm View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nils Barth (inactive)
Not sure correct way to do this; this just returns the result of imp->attributeName() directly. ...
7 years ago (2013-12-19 06:01:14 UTC) #1
Nils Barth (inactive)
On 2013/12/19 06:01:14, Nils Barth wrote: > Not sure correct way to do this; > ...
7 years ago (2013-12-19 07:15:58 UTC) #2
haraken
7 years ago (2013-12-19 10:40:25 UTC) #3
On 2013/12/19 07:15:58, Nils Barth wrote:
> On 2013/12/19 06:01:14, Nils Barth wrote:
> > Not sure correct way to do this;
> > this just returns the result of imp->attributeName() directly.
> > Is there anything else involved?
> 
> This breaks many tests (b/c it's not returning the event listener function
> correctly);
> what should we be returning?
> (Should we be using V8EventListenerList::getEventListener ?)

Yes, we must use V8EventListenerList::getEventListener(), otherwise a listener
wrapper won't be prepared.

You also need to change a return type of C++ methods from EventListener* to
PassRefPtr<EventListener>.

Powered by Google App Engine
This is Rietveld 408576698