Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: Source/bindings/scripts/code_generator_v8.pm

Issue 115873003: EventHandler getters return RefPtr<EventListener> (not v8::Handle<v8::Value>) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/bindings/tests/results/V8TestInterface.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org> 1 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
2 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com> 2 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com>
3 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com> 3 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
4 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org> 4 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org>
5 # Copyright (C) 2006 Apple Computer, Inc. 5 # Copyright (C) 2006 Apple Computer, Inc.
6 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc. 6 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc.
7 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au> 7 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
8 # Copyright (C) Research In Motion Limited 2010. All rights reserved. 8 # Copyright (C) Research In Motion Limited 2010. All rights reserved.
9 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 # Copyright (C) 2012 Ericsson AB. All rights reserved. 10 # Copyright (C) 2012 Ericsson AB. All rights reserved.
(...skipping 1711 matching lines...) Expand 10 before | Expand all | Expand 10 after
1722 my ($functionName, @arguments) = GetterExpression($interfaceName, $attri bute); 1722 my ($functionName, @arguments) = GetterExpression($interfaceName, $attri bute);
1723 my $implementedBy = $attribute->extendedAttributes->{"ImplementedBy"}; 1723 my $implementedBy = $attribute->extendedAttributes->{"ImplementedBy"};
1724 if ($implementedBy) { 1724 if ($implementedBy) {
1725 my $implementedByImplName = GetImplNameFromImplementedBy($implemente dBy); 1725 my $implementedByImplName = GetImplNameFromImplementedBy($implemente dBy);
1726 $functionName = "${implementedByImplName}::${functionName}"; 1726 $functionName = "${implementedByImplName}::${functionName}";
1727 push(@arguments, "imp"); 1727 push(@arguments, "imp");
1728 } else { 1728 } else {
1729 $functionName = "imp->${functionName}"; 1729 $functionName = "imp->${functionName}";
1730 } 1730 }
1731 push(@arguments, "isolatedWorldForIsolate(info.GetIsolate())"); 1731 push(@arguments, "isolatedWorldForIsolate(info.GetIsolate())");
1732 $code .= " EventListener* jsValue = ${functionName}(" . join(", ", @a rguments) . ");\n"; 1732 $code .= " RefPtr<EventListener> listener = ${functionName}(" . join( ", ", @arguments) . ");\n";
1733 $code .= " v8SetReturnValue(info, jsValue ? v8::Handle<v8::Value>(V8A bstractEventListener::cast(jsValue)->getListenerObject(imp->executionContext())) : v8::Handle<v8::Value>(v8::Null(info.GetIsolate())));\n"; 1733 $code .= " v8SetReturnValue(info, listener);\n";
1734 } else { 1734 } else {
1735 my $nativeValue = NativeToJSValue($attribute->type, $attribute->extended Attributes, $expression, " ", "", "info.GetIsolate()", "info", "imp", $forMai nWorldSuffix, "return"); 1735 my $nativeValue = NativeToJSValue($attribute->type, $attribute->extended Attributes, $expression, " ", "", "info.GetIsolate()", "info", "imp", $forMai nWorldSuffix, "return");
1736 $code .= "${nativeValue}\n"; 1736 $code .= "${nativeValue}\n";
1737 } 1737 }
1738 1738
1739 $code .= "}\n"; # end of getter 1739 $code .= "}\n"; # end of getter
1740 $code .= "#endif // ${conditionalString}\n" if $conditionalString; 1740 $code .= "#endif // ${conditionalString}\n" if $conditionalString;
1741 $code .= "\n"; 1741 $code .= "\n";
1742 $implementation{nameSpaceInternal}->add($code); 1742 $implementation{nameSpaceInternal}->add($code);
1743 } 1743 }
(...skipping 4638 matching lines...) Expand 10 before | Expand all | Expand 10 after
6382 6382
6383 foreach my $parameter (@{$function->parameters}) { 6383 foreach my $parameter (@{$function->parameters}) {
6384 if ($parameter->type eq "SerializedScriptValue") { 6384 if ($parameter->type eq "SerializedScriptValue") {
6385 return 1; 6385 return 1;
6386 } 6386 }
6387 } 6387 }
6388 return 0; 6388 return 0;
6389 } 6389 }
6390 6390
6391 1; 6391 1;
OLDNEW
« no previous file with comments | « no previous file | Source/bindings/tests/results/V8TestInterface.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698