Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1158693005: Add an API to set the ColorFilter on a Paint object. (Closed)

Created:
5 years, 6 months ago by Matt Perry
Modified:
5 years, 6 months ago
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : abarth #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -24 lines) Patch
M sky/engine/core/core.gni View 2 chunks +3 lines, -0 lines 0 comments Download
A sky/engine/core/painting/ColorFilter.h View 1 chunk +31 lines, -0 lines 0 comments Download
A sky/engine/core/painting/ColorFilter.cpp View 1 chunk +25 lines, -0 lines 0 comments Download
A + sky/engine/core/painting/ColorFilter.idl View 1 chunk +4 lines, -3 lines 0 comments Download
M sky/engine/core/painting/LayerDrawLooperBuilder.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/engine/core/painting/Paint.h View 2 chunks +2 lines, -0 lines 0 comments Download
M sky/engine/core/painting/Paint.cpp View 2 chunks +7 lines, -0 lines 0 comments Download
M sky/engine/core/painting/Paint.idl View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/platform/graphics/GraphicsContext.h View 3 chunks +3 lines, -3 lines 0 comments Download
M sky/engine/platform/graphics/GraphicsContext.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M sky/engine/platform/graphics/GraphicsTypes.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/raw/painting.sky View 1 2 chunks +14 lines, -7 lines 0 comments Download
A sky/examples/raw/shadow.dart View 1 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Matt Perry
5 years, 6 months ago (2015-05-28 20:33:07 UTC) #2
abarth-chromium
lgtm https://codereview.chromium.org/1158693005/diff/1/sky/examples/raw/shadow.dart File sky/examples/raw/shadow.dart (right): https://codereview.chromium.org/1158693005/diff/1/sky/examples/raw/shadow.dart#newcode27 sky/examples/raw/shadow.dart:27: canvas.drawRect(new Rect()..setLTRB(-size, -size, size, size), paint); new Rect.fromLTRB(-size, ...
5 years, 6 months ago (2015-05-28 20:36:14 UTC) #4
Matt Perry
5 years, 6 months ago (2015-05-28 21:17:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
69b211c94143d6fbd53304dd604e0cadf2b443a6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698