Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issue 1158693002: Call setNeedsLayout instead of invalidate when scheduling plugin webview animation. (Closed)

Created:
5 years, 7 months ago by chrishtr
Modified:
5 years, 7 months ago
Reviewers:
tommycli
CC:
chromium-reviews, Stephen Chennney, Xianzhu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call setNeedsLayout instead of invalidate when scheduling plugin webview animation. scheduleAnimation could be called for a variety of reasons, but we need to assume that layout and not just paint invalidation is needed, in order to avoid stale layout state during paint of the plugin's WebView. BUG=436562 Committed: https://crrev.com/e47161e40995ae6edc1fe9277d81a0878a59bdd1 Cr-Commit-Position: refs/heads/master@{#331402}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/plugins/renderer/webview_plugin.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
chrishtr
5 years, 7 months ago (2015-05-25 23:58:39 UTC) #2
chrishtr
5 years, 7 months ago (2015-05-25 23:59:30 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158693002/20001
5 years, 7 months ago (2015-05-26 17:05:00 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-26 17:51:43 UTC) #7
tommycli
lgtm
5 years, 7 months ago (2015-05-26 18:15:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158693002/20001
5 years, 7 months ago (2015-05-26 18:36:37 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-26 19:21:40 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-26 19:22:38 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e47161e40995ae6edc1fe9277d81a0878a59bdd1
Cr-Commit-Position: refs/heads/master@{#331402}

Powered by Google App Engine
This is Rietveld 408576698