Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Side by Side Diff: components/plugins/renderer/webview_plugin.cc

Issue 1158693002: Call setNeedsLayout instead of invalidate when scheduling plugin webview animation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/plugins/renderer/webview_plugin.h" 5 #include "components/plugins/renderer/webview_plugin.h"
6 6
7 #include "base/message_loop/message_loop.h" 7 #include "base/message_loop/message_loop.h"
8 #include "base/metrics/histogram.h" 8 #include "base/metrics/histogram.h"
9 #include "base/numerics/safe_conversions.h" 9 #include "base/numerics/safe_conversions.h"
10 #include "content/public/common/web_preferences.h" 10 #include "content/public/common/web_preferences.h"
(...skipping 240 matching lines...) Expand 10 before | Expand all | Expand 10 after
251 if (container_) 251 if (container_)
252 container_->invalidateRect(rect); 252 container_->invalidateRect(rect);
253 } 253 }
254 254
255 void WebViewPlugin::didChangeCursor(const WebCursorInfo& cursor) { 255 void WebViewPlugin::didChangeCursor(const WebCursorInfo& cursor) {
256 current_cursor_ = cursor; 256 current_cursor_ = cursor;
257 } 257 }
258 258
259 void WebViewPlugin::scheduleAnimation() { 259 void WebViewPlugin::scheduleAnimation() {
260 if (container_) 260 if (container_)
261 container_->invalidate(); 261 container_->setNeedsLayout();
262 } 262 }
263 263
264 void WebViewPlugin::didClearWindowObject(WebLocalFrame* frame) { 264 void WebViewPlugin::didClearWindowObject(WebLocalFrame* frame) {
265 if (delegate_) 265 if (delegate_)
266 delegate_->BindWebFrame(frame); 266 delegate_->BindWebFrame(frame);
267 } 267 }
268 268
269 void WebViewPlugin::didReceiveResponse(WebLocalFrame* frame, 269 void WebViewPlugin::didReceiveResponse(WebLocalFrame* frame,
270 unsigned identifier, 270 unsigned identifier,
271 const WebURLResponse& response) { 271 const WebURLResponse& response) {
272 WebFrameClient::didReceiveResponse(frame, identifier, response); 272 WebFrameClient::didReceiveResponse(frame, identifier, response);
273 } 273 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698