Source/core/layout/LayoutBox.cpp - Issue 1158673006: Replace various ScrollableArea scroll methods with setScrollPosition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutBox.cpp

Issue 1158673006: Replace various ScrollableArea scroll methods with setScrollPosition (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/layout/LayoutBox.cpp

diff --git a/Source/core/layout/LayoutBox.cpp b/Source/core/layout/LayoutBox.cpp

index 54e81bfd61e028d623050527e570663c34cf679d..b2946607989df32ff5ac6c54b0b5c3493f01a785 100644

--- a/Source/core/layout/LayoutBox.cpp

+++ b/Source/core/layout/LayoutBox.cpp

@@ -873,7 +873,7 @@ void LayoutBox::scrollByRecursively(const DoubleSize& delta, ScrollOffsetClampin

// If we are here, we were called on a layoutObject that can be programmatically scrolled, but doesn't

// have an overflow clip. Which means that it is a document node that can be scrolled.

// FIXME: Pass in DoubleSize. crbug.com/414283.

- view()->frameView()->scrollBy(flooredIntSize(delta));

+ view()->frameView()->scrollBy(flooredIntSize(delta), UserScroll);

// FIXME: If we didn't scroll the whole way, do we want to try looking at the frames ownerElement?

// https://bugs.webkit.org/show_bug.cgi?id=28237

« no previous file with comments | « Source/core/html/ImageDocument.cpp ('k') | Source/core/page/SpatialNavigation.cpp » ('j') | Source/modules/accessibility/AXObject.cpp » ('J')