Replace various ScrollableArea scroll methods with setScrollPosition

Source/modules/accessibility/AXObject.cpp

Index: Source/modules/accessibility/AXObject.cpp
diff --git a/Source/modules/accessibility/AXObject.cpp b/Source/modules/accessibility/AXObject.cpp
index 21eb762cd0146c48d5b545358409f72b0fd92892..98356a1ddf578970c3b586629d2a2fc682f42f01 100644
--- a/Source/modules/accessibility/AXObject.cpp
+++ b/Source/modules/accessibility/AXObject.cpp
@@ -1086,7 +1086,7 @@ void AXObject::setScrollOffset(const IntPoint& offset) const
     if (!area)
         return;
 
-    area->setScrollPosition(DoublePoint(offset.x(), offset.y()));
+    area->setScrollPosition(DoublePoint(offset.x(), offset.y()), ProgrammaticScroll);

[dmazzoni, 2015/06/09 19:40:23]

What are the implications of this being a programmatic scroll vs user scroll?

Typically we assume accessibility is the agent of the user - for example if a
user with a motor impairment issues a voice command to scroll down the page and
that triggers using accessibility APIs, we should treat that the same as if they
pressed PageDown or flicked their mouse scroll wheel.

For example, we call this before triggering a button press via accessibility:

UserGestureIndicator gestureIndicator(DefinitelyProcessingNewUserGesture);

Does that sound okay or am I misunderstanding the difference between user and
programmatic here?

[bokan, 2015/06/09 20:03:01]

Hmm...right now the only implication here is which ScrollAnimator gets used. We
have separate animators for user and programmatic scrolls (I'm not sure why) and
a scroll through one cancels any animations on the other.

The call I'm replacing here was taking the programmatic scroll path. In that
case, should this and AXScrollbar be a UserScroll? Functionally, I don't think
it makes much difference right now but we may key more info off this in the
future.

 }
 
 //