Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: runtime/vm/cha_test.cc

Issue 1158673004: Do not eagerly add guarded leaf classes with CHA; do not add them for private names. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: typos in comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/cha_test.cc
diff --git a/runtime/vm/cha_test.cc b/runtime/vm/cha_test.cc
index 3926daa62bc508ac3a43799c15b6fe5943668104..1cd95dc4e306ab9920c2135e55cabf7103618616 100644
--- a/runtime/vm/cha_test.cc
+++ b/runtime/vm/cha_test.cc
@@ -89,7 +89,9 @@ TEST_CASE(ClassHierarchyAnalysis) {
EXPECT(cha.HasSubclasses(class_a));
EXPECT(cha.HasSubclasses(class_b));
EXPECT(!cha.HasSubclasses(class_c));
+ cha.AddToLeafClasses(class_c);
EXPECT(!cha.HasSubclasses(class_d));
+ cha.AddToLeafClasses(class_d);
EXPECT(!ContainsCid(cha.leaf_classes(), class_a.id()));
EXPECT(!ContainsCid(cha.leaf_classes(), class_b.id()));

Powered by Google App Engine
This is Rietveld 408576698