Do not eagerly add guarded leaf classes with CHA; do not add them for private names.

runtime/vm/cha.h

Index: runtime/vm/cha.h
diff --git a/runtime/vm/cha.h b/runtime/vm/cha.h
index 9be0caab14c381a28217a7d0ab01e6a6ea2b528c..f0d42fc37cf8ddb73ce97cc828bcef6b7d1531c6 100644
--- a/runtime/vm/cha.h
+++ b/runtime/vm/cha.h
@@ -51,9 +51,12 @@ class CHA : public StackResource {
     return leaf_classes_;
   }
 
- private:
+  // Adds class 'cls' to the list of leaf classes, deoptimization occurs
+  // if any of the leaf classes gets subclassed through later loaded/finalized
+  // libraries.
   void AddToLeafClasses(const Class& cls);

[rmacnak, 2015/05/28 23:16:52]

Add a note that this does not include all leaf classes but only classes were we
made an optimization on the assumption that the class has no
subclasses/implementors.

[srdjan, 2015/05/28 23:28:56]

Done.

 
+ private:
   Thread* thread_;
   GrowableArray<Class*> leaf_classes_;
   CHA* previous_;