Do not eagerly add guarded leaf classes with CHA; do not add them for private names.

runtime/vm/cha.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_CHA_H_
 #define VM_CHA_H_
 
 #include "vm/allocation.h"
 #include "vm/growable_array.h"
 #include "vm/thread.h"
@@ skipping 14 matching lines @@
         previous_(thread->cha()) {
     thread->set_cha(this);
   }
 
   ~CHA() {
     ASSERT(thread_->cha() == this);
     thread_->set_cha(previous_);
   }
 
   // Returns true if the class has subclasses.
   // Updates set of leaf classes that we register optimized code with for lazy

[rmacnak, 2015/05/28 23:16:52]

No longer true.

[srdjan, 2015/05/28 23:28:57]

Removed.

   // deoptimization.
   bool HasSubclasses(const Class& cls);
   bool HasSubclasses(intptr_t cid);
 
   // Return true if the class is implemented by some other class.
   // Updates set of leaf classes that we register optimized code with for lazy

[rmacnak, 2015/05/28 23:16:52]

No longer true.

[srdjan, 2015/05/28 23:28:57]

Removed.

   // deoptimization.
   bool IsImplemented(const Class& cls);
 
   // Returns true if any subclass of 'cls' contains the function.
   // Updates set of leaf classes that we register optimized code with for lazy

[rmacnak, 2015/05/28 23:16:52]

No longer true.

[srdjan, 2015/05/28 23:28:57]

Removed.

   // deoptimization.
   bool HasOverride(const Class& cls, const String& function_name);
 
   const GrowableArray<Class*>& leaf_classes() const {
     return leaf_classes_;
   }
 
- private:
+  // Adds class 'cls' to the list of leaf classes, deoptimization occurs
+  // if any of the leaf classes gets subclassed through later loaded/finalized
+  // libraries.
   void AddToLeafClasses(const Class& cls);

[rmacnak, 2015/05/28 23:16:52]

Add a note that this does not include all leaf classes but only classes were we
made an optimization on the assumption that the class has no
subclasses/implementors.

[srdjan, 2015/05/28 23:28:56]

Done.

 
+ private:
   Thread* thread_;
   GrowableArray<Class*> leaf_classes_;
   CHA* previous_;
 };
 
 }  // namespace dart
 
 #endif  // VM_CHA_H_