Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/spdy/spdy_session.h

Issue 1158653002: Returning scoped_ptr instead of raw pointer in SpdySessionPoolInfoToValue() in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added for GetInfoTovalue Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/log/net_log_util.cc ('K') | « net/log/net_log_util.cc ('k') | net/spdy/spdy_session.cc » ('j') | net/spdy/spdy_session_pool.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_session.h
diff --git a/net/spdy/spdy_session.h b/net/spdy/spdy_session.h
index fdbf73dfc20e8ca40c63d4764dd08f1fcfd82f36..22de148458b0fc8e1b3baa7f5c3b8aef08591458 100644
--- a/net/spdy/spdy_session.h
+++ b/net/spdy/spdy_session.h
@@ -398,7 +398,7 @@ class NET_EXPORT SpdySession : public BufferedSpdyFramerVisitorInterface,
// Retrieves information on the current state of the SPDY session as a
// Value. Caller takes possession of the returned value.
eroman 2015/05/25 17:50:46 Remove comment on ownership
payal.pandey 2015/05/26 06:07:35 Done.
- base::Value* GetInfoAsValue() const;
+ scoped_ptr<base::Value> GetInfoAsValue() const;
// Indicates whether the session is being reused after having successfully
// used to send/receive data in the past or if the underlying socket was idle
« net/log/net_log_util.cc ('K') | « net/log/net_log_util.cc ('k') | net/spdy/spdy_session.cc » ('j') | net/spdy/spdy_session_pool.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698