Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2215)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/spdy/spdy_session_pool.h

Issue 1158653002: Returning scoped_ptr instead of raw pointer in SpdySessionPoolInfoToValue() in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added for GetInfoTovalue Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/spdy/spdy_session.h ('K') | « net/spdy/spdy_session.cc ('k') | net/spdy/spdy_session_pool.cc » ('j') | net/spdy/spdy_session_pool.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_session_pool.h
diff --git a/net/spdy/spdy_session_pool.h b/net/spdy/spdy_session_pool.h
index 13582ed52e5af82c0099a85c6d0cffa4dbbcbec7..d80fbf3dd5d40bc2aa3582e0cbc76e367f01e2aa 100644
--- a/net/spdy/spdy_session_pool.h
+++ b/net/spdy/spdy_session_pool.h
@@ -121,7 +121,7 @@ class NET_EXPORT SpdySessionPool
// Creates a Value summary of the state of the spdy session pool. The caller
eroman 2015/05/25 17:50:46 Remove ownership comment
payal.pandey 2015/05/26 06:07:35 Done.
// responsible for deleting the returned value.
- base::Value* SpdySessionPoolInfoToValue() const;
+ scoped_ptr<base::Value> SpdySessionPoolInfoToValue() const;
base::WeakPtr<HttpServerProperties> http_server_properties() {
return http_server_properties_;
« net/spdy/spdy_session.h ('K') | « net/spdy/spdy_session.cc ('k') | net/spdy/spdy_session_pool.cc » ('j') | net/spdy/spdy_session_pool.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698