tools/clang/blink_gc_plugin/tests/destructor_eagerly_finalized.txt - Issue 1158623002: Extend destructor checks to account for eagerly finalized class types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/destructor_eagerly_finalized.txt

Issue 1158623002: Extend destructor checks to account for eagerly finalized class types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updated to look for IsEagerlyFinalizedMarker instead Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/destructor_eagerly_finalized.cpp ('k') | tools/clang/blink_gc_plugin/tests/heap/stubs.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/destructor_eagerly_finalized.txt

diff --git a/tools/clang/blink_gc_plugin/tests/destructor_eagerly_finalized.txt b/tools/clang/blink_gc_plugin/tests/destructor_eagerly_finalized.txt

new file mode 100644

index 0000000000000000000000000000000000000000..97d50897044053c28767f0e800b6700ef0df9777

--- /dev/null

+++ b/tools/clang/blink_gc_plugin/tests/destructor_eagerly_finalized.txt

@@ -0,0 +1,13 @@

+destructor_eagerly_finalized.cpp:26:5: warning: [blink-gc] Finalizer '~HeapObjectEagerFinalizedAlso' accesses eagerly finalized field 'm_heapObjectFinalized'.

+ m_heapObjectFinalized->foo();

+ ^

+./destructor_eagerly_finalized.h:41:5: note: [blink-gc] Field 'm_heapObjectFinalized' having eagerly finalized value, declared here:

+ Member<HeapObjectEagerFinalized> m_heapObjectFinalized;

+ ^

+destructor_eagerly_finalized.cpp:27:5: warning: [blink-gc] Finalizer '~HeapObjectEagerFinalizedAlso' accesses eagerly finalized field 'm_heapVector'.

+ m_heapVector[0]->foo();

+ ^

+./destructor_eagerly_finalized.h:42:5: note: [blink-gc] Field 'm_heapVector' having eagerly finalized value, declared here:

+ HeapVector<Member<HeapObjectEagerFinalized>> m_heapVector;

+ ^

+2 warnings generated.