tools/clang/blink_gc_plugin/tests/destructor_eagerly_finalized.txt - Issue 1158623002: Extend destructor checks to account for eagerly finalized class types.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/blink_gc_plugin/tests/destructor_eagerly_finalized.txt

Issue 1158623002: Extend destructor checks to account for eagerly finalized class types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updated to look for IsEagerlyFinalizedMarker instead Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 destructor_eagerly_finalized.cpp:26:5: warning: [blink-gc] Finalizer '~HeapObjec tEagerFinalizedAlso' accesses eagerly finalized field 'm_heapObjectFinalized'.

	2 m_heapObjectFinalized->foo();

	3 ^

	4 ./destructor_eagerly_finalized.h:41:5: note: [blink-gc] Field 'm_heapObjectFinal ized' having eagerly finalized value, declared here:

	5 Member<HeapObjectEagerFinalized> m_heapObjectFinalized;

	6 ^

	7 destructor_eagerly_finalized.cpp:27:5: warning: [blink-gc] Finalizer '~HeapObjec tEagerFinalizedAlso' accesses eagerly finalized field 'm_heapVector'.

	8 m_heapVector[0]->foo();

	9 ^

	10 ./destructor_eagerly_finalized.h:42:5: note: [blink-gc] Field 'm_heapVector' hav ing eagerly finalized value, declared here:

	11 HeapVector<Member<HeapObjectEagerFinalized>> m_heapVector;

	12 ^

	13 2 warnings generated.

OLD	NEW