Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Unified Diff: Source/core/layout/svg/LayoutSVGEllipse.h

Issue 1158583003: Reduce how often LayoutSVGShape::updateShapeFromElement is called (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix marker regression Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/layout/svg/LayoutSVGEllipse.h
diff --git a/Source/core/layout/svg/LayoutSVGEllipse.h b/Source/core/layout/svg/LayoutSVGEllipse.h
index 2b0377bb667346e7f35b27ba5f846dc133889baa..d6c4975df0c052016b5f3d5d9b6cb90e26d6fe19 100644
--- a/Source/core/layout/svg/LayoutSVGEllipse.h
+++ b/Source/core/layout/svg/LayoutSVGEllipse.h
@@ -41,7 +41,8 @@ public:
virtual const char* name() const override { return "LayoutSVGEllipse"; }
private:
- virtual void updateShapeFromElement() override;
+ void updateShapeFromElement() override final;
fs 2015/06/16 10:54:02 Nit: This class is final
pdr. 2015/06/17 03:50:49 Done
+ void updateStrokeAndFillBoundingBoxes() override final;
virtual bool isShapeEmpty() const override { return m_usePathFallback ? LayoutSVGShape::isShapeEmpty() : m_fillBoundingBox.isEmpty(); }
virtual bool shapeDependentStrokeContains(const FloatPoint&) override;
virtual bool shapeDependentFillContains(const FloatPoint&, const WindRule) const override;
« no previous file with comments | « no previous file | Source/core/layout/svg/LayoutSVGEllipse.cpp » ('j') | Source/core/layout/svg/LayoutSVGEllipse.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698