Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: Source/core/layout/svg/LayoutSVGEllipse.h

Issue 1158583003: Reduce how often LayoutSVGShape::updateShapeFromElement is called (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix marker regression Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google, Inc. 2 * Copyright (C) 2012 Google, Inc.
3 * All rights reserved. 3 * All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 23 matching lines...) Expand all
34 class LayoutSVGEllipse final : public LayoutSVGShape { 34 class LayoutSVGEllipse final : public LayoutSVGShape {
35 public: 35 public:
36 explicit LayoutSVGEllipse(SVGGeometryElement*); 36 explicit LayoutSVGEllipse(SVGGeometryElement*);
37 virtual ~LayoutSVGEllipse(); 37 virtual ~LayoutSVGEllipse();
38 38
39 virtual ShapeGeometryCodePath geometryCodePath() const override { return m_u sePathFallback ? PathGeometry : EllipseGeometryFastPath; } 39 virtual ShapeGeometryCodePath geometryCodePath() const override { return m_u sePathFallback ? PathGeometry : EllipseGeometryFastPath; }
40 40
41 virtual const char* name() const override { return "LayoutSVGEllipse"; } 41 virtual const char* name() const override { return "LayoutSVGEllipse"; }
42 42
43 private: 43 private:
44 virtual void updateShapeFromElement() override; 44 void updateShapeFromElement() override final;
fs 2015/06/16 10:54:02 Nit: This class is final
pdr. 2015/06/17 03:50:49 Done
45 void updateStrokeAndFillBoundingBoxes() override final;
45 virtual bool isShapeEmpty() const override { return m_usePathFallback ? Layo utSVGShape::isShapeEmpty() : m_fillBoundingBox.isEmpty(); } 46 virtual bool isShapeEmpty() const override { return m_usePathFallback ? Layo utSVGShape::isShapeEmpty() : m_fillBoundingBox.isEmpty(); }
46 virtual bool shapeDependentStrokeContains(const FloatPoint&) override; 47 virtual bool shapeDependentStrokeContains(const FloatPoint&) override;
47 virtual bool shapeDependentFillContains(const FloatPoint&, const WindRule) c onst override; 48 virtual bool shapeDependentFillContains(const FloatPoint&, const WindRule) c onst override;
48 void calculateRadiiAndCenter(); 49 void calculateRadiiAndCenter();
49 bool hasContinuousStroke() const; 50 bool hasContinuousStroke() const;
50 51
51 private: 52 private:
52 FloatPoint m_center; 53 FloatPoint m_center;
53 FloatSize m_radii; 54 FloatSize m_radii;
54 bool m_usePathFallback; 55 bool m_usePathFallback;
55 }; 56 };
56 57
57 } 58 }
58 59
59 #endif 60 #endif
OLDNEW
« no previous file with comments | « no previous file | Source/core/layout/svg/LayoutSVGEllipse.cpp » ('j') | Source/core/layout/svg/LayoutSVGEllipse.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698