Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1158553004: cc: Cull DrawingDisplayItems outside of the raster playback rect (Closed)

Created:
5 years, 6 months ago by danakj
Modified:
5 years, 6 months ago
Reviewers:
vmpstr, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, piman, sky, sadrul, pdr., chrishtr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Cull DrawingDisplayItems outside of the raster playback rect Avoid playing an SkPicture into the raster canvas at all if its bounds are not going to intersect what is being rastered. This is for the non-cached picture path which is only used by the ui compositor at this time. This improves the time to raster a single tab loading spinner in the ui compositor from 0.0807235 ms to 0.0597263 for 26% less raster time. BUG=487387 Committed: https://crrev.com/fb311cbcfcc06427a037ee01c7f0a3098a060e03 Cr-Commit-Position: refs/heads/master@{#332730}

Patch Set 1 #

Patch Set 2 : cull: . #

Patch Set 3 : cull: . #

Patch Set 4 : cull: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -14 lines) Patch
M cc/playback/clip_display_item.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M cc/playback/clip_display_item.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M cc/playback/clip_path_display_item.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M cc/playback/clip_path_display_item.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M cc/playback/compositing_display_item.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M cc/playback/compositing_display_item.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M cc/playback/display_item.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/playback/display_item_list.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/playback/display_item_list.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M cc/playback/display_list_raster_source.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M cc/playback/display_list_recording_source.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/playback/drawing_display_item.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/playback/drawing_display_item.cc View 1 2 chunks +12 lines, -0 lines 0 comments Download
M cc/playback/filter_display_item.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M cc/playback/filter_display_item.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M cc/playback/float_clip_display_item.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M cc/playback/float_clip_display_item.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M cc/playback/transform_display_item.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M cc/playback/transform_display_item.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M cc/test/skia_common.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
danakj
5 years, 6 months ago (2015-06-03 23:04:31 UTC) #2
danakj
Idk how to test this, I need to know that some DisplayItem did not raster.. ...
5 years, 6 months ago (2015-06-03 23:05:27 UTC) #3
enne (OOO)
lgtm I'm not super keen on having that sort of wart just for testing. I ...
5 years, 6 months ago (2015-06-03 23:14:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158553004/60001
5 years, 6 months ago (2015-06-03 23:25:22 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-03 23:42:10 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 23:44:10 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/fb311cbcfcc06427a037ee01c7f0a3098a060e03
Cr-Commit-Position: refs/heads/master@{#332730}

Powered by Google App Engine
This is Rietveld 408576698