Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Side by Side Diff: cc/playback/float_clip_display_item.cc

Issue 1158553004: cc: Cull DrawingDisplayItems outside of the raster playback rect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cull: . Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/playback/float_clip_display_item.h ('k') | cc/playback/transform_display_item.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/playback/float_clip_display_item.h" 5 #include "cc/playback/float_clip_display_item.h"
6 6
7 #include "base/strings/stringprintf.h" 7 #include "base/strings/stringprintf.h"
8 #include "base/trace_event/trace_event_argument.h" 8 #include "base/trace_event/trace_event_argument.h"
9 #include "third_party/skia/include/core/SkCanvas.h" 9 #include "third_party/skia/include/core/SkCanvas.h"
10 #include "ui/gfx/skia_util.h" 10 #include "ui/gfx/skia_util.h"
11 11
12 namespace cc { 12 namespace cc {
13 13
14 FloatClipDisplayItem::FloatClipDisplayItem() { 14 FloatClipDisplayItem::FloatClipDisplayItem() {
15 } 15 }
16 16
17 FloatClipDisplayItem::~FloatClipDisplayItem() { 17 FloatClipDisplayItem::~FloatClipDisplayItem() {
18 } 18 }
19 19
20 void FloatClipDisplayItem::SetNew(const gfx::RectF& clip_rect) { 20 void FloatClipDisplayItem::SetNew(const gfx::RectF& clip_rect) {
21 clip_rect_ = clip_rect; 21 clip_rect_ = clip_rect;
22 22
23 size_t memory_usage = sizeof(gfx::RectF); 23 size_t memory_usage = sizeof(gfx::RectF);
24 DisplayItem::SetNew(true /* suitable_for_gpu_raster */, 1 /* op_count */, 24 DisplayItem::SetNew(true /* suitable_for_gpu_raster */, 1 /* op_count */,
25 memory_usage); 25 memory_usage);
26 } 26 }
27 27
28 void FloatClipDisplayItem::Raster(SkCanvas* canvas, 28 void FloatClipDisplayItem::Raster(SkCanvas* canvas,
29 const gfx::Rect& canvas_target_playback_rect,
29 SkPicture::AbortCallback* callback) const { 30 SkPicture::AbortCallback* callback) const {
30 canvas->save(); 31 canvas->save();
31 canvas->clipRect(gfx::RectFToSkRect(clip_rect_)); 32 canvas->clipRect(gfx::RectFToSkRect(clip_rect_));
32 } 33 }
33 34
34 void FloatClipDisplayItem::AsValueInto( 35 void FloatClipDisplayItem::AsValueInto(
35 base::trace_event::TracedValue* array) const { 36 base::trace_event::TracedValue* array) const {
36 array->AppendString(base::StringPrintf("FloatClipDisplayItem rect: [%s]", 37 array->AppendString(base::StringPrintf("FloatClipDisplayItem rect: [%s]",
37 clip_rect_.ToString().c_str())); 38 clip_rect_.ToString().c_str()));
38 } 39 }
39 40
40 EndFloatClipDisplayItem::EndFloatClipDisplayItem() { 41 EndFloatClipDisplayItem::EndFloatClipDisplayItem() {
41 DisplayItem::SetNew(true /* suitable_for_gpu_raster */, 0 /* op_count */, 42 DisplayItem::SetNew(true /* suitable_for_gpu_raster */, 0 /* op_count */,
42 0 /* memory_usage */); 43 0 /* memory_usage */);
43 } 44 }
44 45
45 EndFloatClipDisplayItem::~EndFloatClipDisplayItem() { 46 EndFloatClipDisplayItem::~EndFloatClipDisplayItem() {
46 } 47 }
47 48
48 void EndFloatClipDisplayItem::Raster(SkCanvas* canvas, 49 void EndFloatClipDisplayItem::Raster(
49 SkPicture::AbortCallback* callback) const { 50 SkCanvas* canvas,
51 const gfx::Rect& canvas_target_playback_rect,
52 SkPicture::AbortCallback* callback) const {
50 canvas->restore(); 53 canvas->restore();
51 } 54 }
52 55
53 void EndFloatClipDisplayItem::AsValueInto( 56 void EndFloatClipDisplayItem::AsValueInto(
54 base::trace_event::TracedValue* array) const { 57 base::trace_event::TracedValue* array) const {
55 array->AppendString("EndFloatClipDisplayItem"); 58 array->AppendString("EndFloatClipDisplayItem");
56 } 59 }
57 60
58 } // namespace cc 61 } // namespace cc
OLDNEW
« no previous file with comments | « cc/playback/float_clip_display_item.h ('k') | cc/playback/transform_display_item.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698