Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Unified Diff: chrome/browser/extensions/extension_tab_util.cc

Issue 1158523002: Add user_gesture param to BaseWindow::Show Base URL: https://chromium.googlesource.com/chromium/src.git@ug3_BaseWindow_Activate
Patch Set: Update callers Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_api.cc ('k') | chrome/browser/net/sdch_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_tab_util.cc
diff --git a/chrome/browser/extensions/extension_tab_util.cc b/chrome/browser/extensions/extension_tab_util.cc
index f1783f72ecba294145bea60075ecb628e8dd1d18..cd9505fb9474f447c84c80297837440b088ca5b2 100644
--- a/chrome/browser/extensions/extension_tab_util.cc
+++ b/chrome/browser/extensions/extension_tab_util.cc
@@ -102,7 +102,8 @@ Browser* CreateBrowser(ChromeUIThreadExtensionFunction* function,
Browser::CreateParams params(
Browser::TYPE_TABBED, function->GetProfile(), desktop_type);
Browser* browser = new Browser(params);
- browser->window()->Show();
+ // TODO(johnme): Can we sometimes be certain this was for a user gesture?
+ browser->window()->Show(false /* user_gesture */);
return browser;
}
@@ -217,7 +218,8 @@ base::DictionaryValue* ExtensionTabUtil::OpenTab(
if (!browser) {
browser = new Browser(
Browser::CreateParams(Browser::TYPE_TABBED, profile, desktop_type));
- browser->window()->Show();
+ // TODO(johnme): Can we sometimes be certain this was for a user gesture?
+ browser->window()->Show(false /* user_gesture */);
}
}
« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_api.cc ('k') | chrome/browser/net/sdch_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698