LayoutTests/fast/dom/Attr/child-nodes-length-cache.html - Issue 1158433004: Remove Attr child nodes (making Attr a Node, not a ContainerNode)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/Attr/child-nodes-length-cache.html

Issue 1158433004: Remove Attr child nodes (making Attr a Node, not a ContainerNode) (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: address feedback Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/Attr/child-nodes-cache-expected.txt ('k') | LayoutTests/fast/dom/Attr/child-nodes-length-cache-expected.txt » ('j') | Source/core/dom/Attr.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/Attr/child-nodes-length-cache.html

diff --git a/LayoutTests/fast/dom/Attr/child-nodes-length-cache.html b/LayoutTests/fast/dom/Attr/child-nodes-length-cache.html

deleted file mode 100644

index f63ef5a5e1af7a325068026032f9c2654d5066f1..0000000000000000000000000000000000000000

--- a/LayoutTests/fast/dom/Attr/child-nodes-length-cache.html

+++ /dev/null

@@ -1,38 +0,0 @@

-<html>

-<head>

-<script>

-if (window.testRunner)

- testRunner.dumpAsText();

-function onLoad()

- var theDiv = document.getElementById("theDiv");

- var theAttrs = theDiv.attributes;

- var nameAttr = theAttrs.getNamedItem("name");

- var nameAttrChildNodes = nameAttr.childNodes;

- var textNode = document.createTextNode("terday");

- var unused = nameAttrChildNodes.length;

- nameAttr.appendChild(textNode);

- var name2Attr = theAttrs.getNamedItem("name2");

- var name2AttrChildNodes = name2Attr.childNodes;

- var textNode2 = document.createTextNode("terday");

- name2Attr.appendChild(textNode2);

- if (nameAttrChildNodes.length != name2AttrChildNodes.length)

- document.getElementById("result").innerHTML = "Failed: nameAttrChildNodes.length=" + nameAttrChildNodes.length + ", name2AttrChildNodes.length=" + name2AttrChildNodes.length;

- else

- document.getElementById("result").innerHTML = "Passed!!";

- document.body.removeChild(document.getElementById("theDiv"));

-</script>

-</head>

-<body onload="onLoad();">

-<p>Test for <a href="https://bugs.webkit.org/show_bug.cgi?id=19759">bug 19759</a>:

-ChildNodeList for an attribute node is not properly invalidated after appending a child.</p>

-<div id="theDiv" name="Yes" name2="Yes">Hello</div>

-<div id="result">Testing...</div>

-</body>

-</html>